[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 119393: Offline cores segmentation fault fix
From:       "Isaac Gomez" <isaac () isaalx ! org>
Date:       2014-07-22 3:21:25
Message-ID: 20140722032125.14616.89059 () probe ! kde ! org
[Download RAW message or body]

--===============4809804253802331206==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119393/
-----------------------------------------------------------

Review request for kde-workspace.


Repository: ksysguard


Description
-------

[PATCH] Offline cores segmentation fault fix


Diffs
-----

  ksysguard/ksysguardd/Linux/cpuinfo.c 9427ec0 
  ksysguard/ksysguardd/Linux/stat.c 534a465 

Diff: https://git.reviewboard.kde.org/r/119393/diff/


Testing
-------

ksysguardd gets segmentation fault if a processor from the middle is offline because \
it takes de id as and array index; for example if we have the core 0 and 2 online but \
not the 1, the program will crash when trying to access array index 2 at the begining \
of the execution. I changed the code to separate the array index from the id's and \
tested with the offline core and also with all the cores online.


Thanks,

Isaac Gomez


--===============4809804253802331206==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119393/">https://git.reviewboard.kde.org/r/119393/</a>
  </td>
    </tr>
   </table>
   <br />





<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kde-workspace.</div>
<div>By Isaac Gomez.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ksysguard
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">[PATCH] Offline cores segmentation fault fix</p></pre> \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">ksysguardd gets segmentation fault if a processor from \
the middle is offline because it takes de id as and array index; for example if we \
have the core 0 and 2 online but not the 1, the program will crash when trying to \
access array index 2 at the begining of the execution.<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> I \
changed the code to separate the array index from the id's and tested with the \
offline core and also with all the cores online.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksysguard/ksysguardd/Linux/cpuinfo.c <span style="color: \
grey">(9427ec0)</span></li>

 <li>ksysguard/ksysguardd/Linux/stat.c <span style="color: \
grey">(534a465)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119393/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>




  </div>
 </body>
</html>


--===============4809804253802331206==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic