[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 118994: make CTRL+SHIFT+T reopen last closed tab
From: "Frank Reininghaus" <frank78ac () googlemail ! com>
Date: 2014-07-21 22:30:37
Message-ID: 20140721223037.14616.84462 () probe ! kde ! org
[Download RAW message or body]
--===============5817989267563303254==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On July 20, 2014, 9:56 p.m., Frank Reininghaus wrote:
> > Thank you very much for working on this, Arjun, and thanks also for your very good \
> > suggestions, Emmanuel!
> > I apologize for not responding earlier. I was a bit busy at work recently and did not \
> > really find the time to check all mails and review request notifications in my inbox and \
> > see which of them could (and should) be handled quickly nevertheless (like this one).
> > Looks very good from my point of view. Please go ahead and push it. I have one minor \
> > suggestion for a change, but feel free to ignore it if you prefer, it's probably a matter \
> > of taste.
> > Thanks again for adding a useful feature, which many users will appreciate.
>
> Arjun Ak wrote:
> Which branch should this be pushed to master or frameworks?
Push to master, please.
- Frank
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118994/#review62753
-----------------------------------------------------------
On July 6, 2014, 1:58 p.m., Arjun Ak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118994/
> -----------------------------------------------------------
>
> (Updated July 6, 2014, 1:58 p.m.)
>
>
> Review request for Dolphin and KDE Base Apps.
>
>
> Bugs: 336818
> http://bugs.kde.org/show_bug.cgi?id=336818
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Upon pressing CTRL+SHIFT+T, the most recently closed tab is reopened (with the help of \
> Go->'Recently closed tabs' menu).
>
> Diffs
> -----
>
> dolphin/src/dolphinmainwindow.h 7c3bff4
> dolphin/src/dolphinmainwindow.cpp d9fe645
> dolphin/src/dolphinrecenttabsmenu.h 34d4153
> dolphin/src/dolphinrecenttabsmenu.cpp a39f994
> dolphin/src/dolphinui.rc 52826bb
>
> Diff: https://git.reviewboard.kde.org/r/118994/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Ak
>
>
--===============5817989267563303254==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118994/">https://git.reviewboard.kde.org/r/118994/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 20th, 2014, 9:56 p.m. UTC, <b>Frank Reininghaus</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank you very much for working \
on this, Arjun, and thanks also for your very good suggestions, Emmanuel!</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I apologize for not responding earlier. I was a bit busy at work recently and did not \
really find the time to check all mails and review request notifications in my inbox and see \
which of them could (and should) be handled quickly nevertheless (like this one).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Looks very good from my point of view. Please go ahead and push it. I have one minor \
suggestion for a change, but feel free to ignore it if you prefer, it's probably a matter of \
taste.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Thanks again for adding a useful feature, which many users will \
appreciate.</p></pre> </blockquote>
<p>On July 21st, 2014, 9:49 a.m. UTC, <b>Arjun Ak</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Which branch should this be \
pushed to master or frameworks?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Push to master, please.</p></pre> \
<br />
<p>- Frank</p>
<br />
<p>On July 6th, 2014, 1:58 p.m. UTC, Arjun Ak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Dolphin and KDE Base Apps.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated July 6, 2014, 1:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=336818">336818</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Upon pressing \
CTRL+SHIFT+T, the most recently closed tab is reopened (with the help of Go->'Recently closed \
tabs' menu).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/dolphinmainwindow.h <span style="color: grey">(7c3bff4)</span></li>
<li>dolphin/src/dolphinmainwindow.cpp <span style="color: grey">(d9fe645)</span></li>
<li>dolphin/src/dolphinrecenttabsmenu.h <span style="color: grey">(34d4153)</span></li>
<li>dolphin/src/dolphinrecenttabsmenu.cpp <span style="color: grey">(a39f994)</span></li>
<li>dolphin/src/dolphinui.rc <span style="color: grey">(52826bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118994/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5817989267563303254==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic