[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 119372: Fix Bug 337486 - Should not permit moving of read-only folder to a differ
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-07-21 18:22:45
Message-ID: 20140721182245.14616.430 () probe ! kde ! org
[Download RAW message or body]
--===============8833514438715228107==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119372/#review62821
-----------------------------------------------------------
lib/konq/konq_operations.cpp
<https://git.reviewboard.kde.org/r/119372/#comment43567>
this indention is wrong (ensure to use the present indention, usually 4 spaces \
per level and NO tabs)
lib/konq/konq_operations.cpp
<https://git.reviewboard.kde.org/r/119372/#comment43568>
there are two whitespaces between "if" and "(" - not that the surrounding lines \
would be very white space consistent, but nevertheless ;-)
lib/konq/konq_operations.cpp
<https://git.reviewboard.kde.org/r/119372/#comment43569>
Try to twist this:
if (!local)
...
else if (QFileInfo((*it).directory()).isWritable()) {
QFileInfo pathInfo(QFileInfo((*it).path());
...
}
This allows you to re-use the QFileInfo object w/o useless overhead and also \
removes a branch level.
- Thomas Lübking
On Juli 21, 2014, 2:12 nachm., Arjun Ak wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119372/
> -----------------------------------------------------------
>
> (Updated Juli 21, 2014, 2:12 nachm.)
>
>
> Review request for KDE Base Apps.
>
>
> Bugs: 337486
> http://bugs.kde.org/show_bug.cgi?id=337486
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Fixes Bug 337486
>
>
> Diffs
> -----
>
> lib/konq/konq_operations.cpp 220a90a
>
> Diff: https://git.reviewboard.kde.org/r/119372/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun Ak
>
>
--===============8833514438715228107==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119372/">https://git.reviewboard.kde.org/r/119372/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119372/diff/3/?file=291457#file291457line474" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/konq/konq_operations.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KonqOperations::doDropFileCopy()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">474</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">mlst</span><span class="p">.</span><span class="n">append</span><span \
class="p">(</span><span class="o">*</span><span class="n">it</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">474</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span \
class="p">(</span><span class="n">local</span><span class="p">)</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this \
indention is wrong (ensure to use the present indention, usually 4 spaces per level \
and NO tabs)</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119372/diff/3/?file=291457#file291457line475" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/konq/konq_operations.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KonqOperations::doDropFileCopy()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">475</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span \
class="n">QFileInfo</span><span class="p">((</span><span class="o">*</span><span \
class="n">it</span><span class="p">).</span><span class="n">directory</span><span \
class="p">()).</span><span class="n">isWritable</span><span class="p">()</span> <span \
class="o">&&</span> <span class="p">(</span><span class="o">!</span><span \
class="n">QFileInfo</span><span class="p">((</span><span class="o">*</span><span \
class="n">it</span><span class="p">).</span><span class="n">path</span><span \
class="p">()).</span><span class="n">isDir</span><span class="p">()</span> <span \
class="o">||</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there \
are two whitespaces between "if" and "(" - not that the surrounding lines would be \
very white space consistent, but nevertheless ;-)</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119372/diff/3/?file=291457#file291457line479" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/konq/konq_operations.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KonqOperations::doDropFileCopy()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">479</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="p">}</span> <span class="k">else</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Try \
to twist this:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">if (!local)<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" />
...<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> else if (QFileInfo((<em style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">it).directory()).isWritable()) {<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> QFileInfo \
pathInfo(QFileInfo((</em>it).path());<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" />
...<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> }</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This allows you to re-use the QFileInfo object w/o \
useless overhead and also removes a branch level.</p></pre> </div>
</div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On Juli 21st, 2014, 2:12 nachm. UTC, Arjun Ak wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Arjun Ak.</div>
<p style="color: grey;"><i>Updated Juli 21, 2014, 2:12 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=337486">337486</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Fixes Bug 337486</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/konq/konq_operations.cpp <span style="color: grey">(220a90a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119372/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8833514438715228107==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic