[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 118180: slideshow BUG patch fix
From: "TOM Harrison" <l12436 () yahoo ! com ! tw>
Date: 2014-07-21 13:07:21
Message-ID: 20140721130721.14617.75918 () probe ! kde ! org
[Download RAW message or body]
--===============6407898500576697845==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On 七月 21, 2014, 12:39 p.m., Martin Gräßlin wrote:
> >
>
> TOM Harrison wrote:
> what kind of issue? tab and space different ?
>
> Sebastian Kügler wrote:
> Yes, don't use tabs at all for code indentation, use 4 spaces. It should look \
> consistent with the surrounding code after that.
OK, I have fix in the patch. I will upload later, if it could detect as a patch......
- TOM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118180/#review62779
-----------------------------------------------------------
On 六月 5, 2014, 10:32 a.m., TOM Harrison wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118180/
> -----------------------------------------------------------
>
> (Updated 六月 5, 2014, 10:32 a.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Bugs: 327580
> http://bugs.kde.org/show_bug.cgi?id=327580
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> bug patch for slideshow dir list missing
>
>
> Diffs
> -----
>
> libs/plasmagenericshell/backgrounddialog.cpp 645de3f
>
> Diff: https://git.reviewboard.kde.org/r/118180/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> TOM Harrison
>
>
--===============6407898500576697845==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118180/">https://git.reviewboard.kde.org/r/118180/</a>
</td>
</tr>
</table>
<br />
<p>On 七月 21st, 2014, 12:59 p.m. UTC, <b>TOM Harrison</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">what \
kind of issue? tab and space different ?</p></pre> </blockquote>
<p>On 七月 21st, 2014, 1:02 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
don't use tabs at all for code indentation, use 4 spaces. It should look consistent \
with the surrounding code after that.</p></pre> </blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, I \
have fix in the patch. I will upload later, if it could detect as a \
patch......</p></pre> <br />
<p>- TOM</p>
<br />
<p>On 六月 5th, 2014, 10:32 a.m. UTC, TOM Harrison wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By TOM Harrison.</div>
<p style="color: grey;"><i>Updated 六月 5, 2014, 10:32 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=327580">327580</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">bug patch for slideshow dir list missing</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/backgrounddialog.cpp <span style="color: \
grey">(645de3f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118180/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6407898500576697845==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic