[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 119363: Port kde-baseapps to use docbook 4.5
From: Marko_Käning <mk-lists () email ! de>
Date: 2014-07-19 12:30:04
Message-ID: 20140719123004.21436.59458 () probe ! kde ! org
[Download RAW message or body]
--===============3395628504599492738==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119363/
-----------------------------------------------------------
(Updated July 19, 2014, 2:30 p.m.)
Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez.
Changes
-------
Change title of RR according to the real topic
Summary (updated)
-----------------
Port kde-baseapps to use docbook 4.5
Repository: kde-baseapps
Description
-------
I need to upgrade the docbook DTD from 4.2 to 4.5 to be able to build this project.
---
I have done similar checkins for other projects like step and kgeography, but I am \
unsure whether this is really the way to go, although Nicolas made the same for \
kalgebra lately.
Luigi wrote in http://mail.kde.org/pipermail/kde-frameworks-devel/2014-July/017471.html \
that this should work with kdelibs4support installed. It is installed on the OSX/CI \
system, but still it doesn't work.
---
So, perhaps it is worthwhile diagnosing what goes wrong there instead of committing \
this RR?!
What can I do to let kdoctools tell me where exactly it expects to find its \
catalogues?
Let me add that kdoctools definitely expects its files in "/Library/Application \
Support/kf5/kdoctools" in my case, because I had to copy them to there manually after \
successfully building kdoctools:
```bash
$ ls /Library/Application\ Support/kf5/kdoctools
customization
```
Also note, that I use this global setting for configurePlatformArgs: \
-DDATA_INSTALL_DIR="Library/Application Support".
Diffs
-----
doc/konqueror/index.docbook a1f8565404be0289b51af37df1687e0911a01fe5
dolphin/docs/index.docbook 5fe85f5d130e3723af556fb02b53970206d1c765
kdepasswd/docs/index.docbook 2ecef470ac8a9384b7aeb16f123f834d040ee375
kfind/docs/index.docbook d46dfa4138991a356eec32a7043a883150eb81c2
kfind/docs/man-kfind.1.docbook ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0
Diff: https://git.reviewboard.kde.org/r/119363/diff/
Testing
-------
Builds/installs fine
Thanks,
Marko Käning
--===============3395628504599492738==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119363/">https://git.reviewboard.kde.org/r/119363/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated July 19, 2014, 2:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change title of RR according to the real topic</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port kde-baseapps to use docbook 4.5</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I need to upgrade the docbook DTD from 4.2 to 4.5 to \
be able to build this project.</p> <hr style="text-rendering: inherit;margin: \
0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" /> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I have done similar checkins for other projects like step and kgeography, \
but I am unsure whether this is really the way to go, although Nicolas made the same \
for kalgebra lately.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Luigi wrote in \
http://mail.kde.org/pipermail/kde-frameworks-devel/2014-July/017471.html that this \
should work with kdelibs4support installed. It is installed on the OSX/CI system, but \
still it doesn't work.</p> <hr style="text-rendering: inherit;margin: 0;padding: \
0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" /> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">So, perhaps it is worthwhile diagnosing what goes wrong there instead of \
committing this RR?!</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">What can I do to let kdoctools tell me \
where exactly it expects to find its catalogues?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Let \
me add that kdoctools definitely expects its files in "/Library/Application \
Support/kf5/kdoctools" in my case, because I had to copy them to there manually after \
successfully building kdoctools:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: \
#19177C">$ </span>ls /Library/Application<span style="color: #BB6622; font-weight: \
bold">\ </span>Support/kf5/kdoctools customization
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Also note, that I use this global setting for \
configurePlatformArgs: -DDATA_INSTALL_DIR="Library/Application Support".</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds/installs fine</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/konqueror/index.docbook <span style="color: \
grey">(a1f8565404be0289b51af37df1687e0911a01fe5)</span></li>
<li>dolphin/docs/index.docbook <span style="color: \
grey">(5fe85f5d130e3723af556fb02b53970206d1c765)</span></li>
<li>kdepasswd/docs/index.docbook <span style="color: \
grey">(2ecef470ac8a9384b7aeb16f123f834d040ee375)</span></li>
<li>kfind/docs/index.docbook <span style="color: \
grey">(d46dfa4138991a356eec32a7043a883150eb81c2)</span></li>
<li>kfind/docs/man-kfind.1.docbook <span style="color: \
grey">(ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119363/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3395628504599492738==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic