[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel
From: "Hui Ni" <shuizhuyuanluo () 126 ! com>
Date: 2014-07-17 15:57:29
Message-ID: 20140717155729.32550.38880 () probe ! kde ! org
[Download RAW message or body]
--===============0444639873298015934==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119025/#review62595
-----------------------------------------------------------
Ship it!
Ship It!
- Hui Ni
On 七月 12, 2014, 1:12 p.m., Vadim Zhukov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119025/
> -----------------------------------------------------------
>
> (Updated 七月 12, 2014, 1:12 p.m.)
>
>
> Review request for kde-workspace, Plasma and Hui Ni.
>
>
> Repository: kimtoy
>
>
> Description
> -------
>
> The ibus-panel can't build on OpenBSD because some required definitions obtained \
> from pkgconfig file are not used. This happens due to the following reasons:
> 1. IBUS_DEFINITIONS is not used in ibus-panel/CMakeLists.txt
> 2. IBUS_DEFINITIONS is not saved in cache, and thus isn't available at compile time
>
> This patch resolves both issues and makes ibus-panel compile on OpenBSD.
>
> (I found no suitable review group and therefore used "plasma" instead, as it was in \
> "plasma-addons" previously; please, feel free to correct me if I'm wrong and sorry \
> for any possible inconvenience)
> ((as there was no feedback for more than a week, I've added "kde-workspace" group \
> to list of reviewers, too))
>
> Diffs
> -----
>
> cmake/FindIBus.cmake 8250c49
> ibus-panel/CMakeLists.txt 3a1ee49
>
> Diff: https://git.reviewboard.kde.org/r/119025/diff/
>
>
> Testing
> -------
>
> OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy package, of course, but the \
> code is same)
>
> Thanks,
>
> Vadim Zhukov
>
>
--===============0444639873298015934==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119025/">https://git.reviewboard.kde.org/r/119025/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre> <br />
<p>- Hui Ni</p>
<br />
<p>On 七月 12th, 2014, 1:12 p.m. UTC, Vadim Zhukov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma and Hui Ni.</div>
<div>By Vadim Zhukov.</div>
<p style="color: grey;"><i>Updated 七月 12, 2014, 1:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kimtoy
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The ibus-panel can't build on OpenBSD because some \
required definitions obtained from pkgconfig file are not used. This happens due to \
the following reasons:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">1. IBUS_DEFINITIONS is not used in \
ibus-panel/CMakeLists.txt<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> 2. IBUS_DEFINITIONS is not saved in \
cache, and thus isn't available at compile time</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
patch resolves both issues and makes ibus-panel compile on OpenBSD.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(I found no suitable review group and therefore used "plasma" instead, as \
it was in "plasma-addons" previously; please, feel free to correct me if I'm wrong \
and sorry for any possible inconvenience)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">((as there was no \
feedback for more than a week, I've added "kde-workspace" group to list of reviewers, \
too))</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">OpenBSD/i386-CURRENT, KDE 4.13 (it doesn't have kimtoy \
package, of course, but the code is same)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/FindIBus.cmake <span style="color: grey">(8250c49)</span></li>
<li>ibus-panel/CMakeLists.txt <span style="color: grey">(3a1ee49)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119025/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0444639873298015934==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic