[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date(
From:       "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date:       2014-07-16 14:31:41
Message-ID: 20140716143141.32550.20072 () probe ! kde ! org
[Download RAW message or body]

--===============1260841621984772103==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit



> On Juli 16, 2014, 2:27 nachm., Nicolás Alvarez wrote:
> > Was this forward-ported to khtml frameworks?

No, it was forward-ported to kjs framework, kjs is not a part of khtml


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118947/#review62512
-----------------------------------------------------------


On Juni 26, 2014, 12:03 nachm., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118947/
> -----------------------------------------------------------
> 
> (Updated Juni 26, 2014, 12:03 nachm.)
> 
> 
> Review request for kdelibs.
> 
> 
> Bugs: 335556
> http://bugs.kde.org/show_bug.cgi?id=335556
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The commit https://projects.kde.org/projects/kde/kdelibs/repository/revisions/48dd1fc50277b861b49613c5f46b6f8b10cc932d \
> introduced a bug: It factors out the code to convert a time specification to an \
> actual time value into the function makeTimeFromList(). But in that function \
> makeTime(&t, ms, true) is called, whereas the original code called makeTime(&t, ms, \
> false) for the constructor. 
> This patch fixes it by passing the "utc" parameter to makeTime() instead of "true".
> 
> Please note that this bug is also present in Frameworks5.
> 
> 
> Diffs
> -----
> 
> kjs/date_object.cpp c8d776c 
> 
> Diff: https://git.reviewboard.kde.org/r/118947/diff/
> 
> 
> Testing
> -------
> 
> Loaded the test case from the bug report into Konqueror/KHTML. The correct time is \
> shown now like in other browsers, including Konqueror/WebKit. 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
> 


--===============1260841621984772103==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118947/">https://git.reviewboard.kde.org/r/118947/</a>
  </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On Juli 16th, 2014, 2:27 nachm. UTC, <b>Nicolás \
Alvarez</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Was this forward-ported to khtml frameworks?</p></pre> \
</blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, \
it was forward-ported to kjs framework, kjs is not a part of khtml</p></pre> <br />










<p>- Bernd</p>


<br />
<p>On Juni 26th, 2014, 12:03 nachm. UTC, Wolfgang Bauer wrote:</p>









<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Wolfgang Bauer.</div>


<p style="color: grey;"><i>Updated Juni 26, 2014, 12:03 nachm.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=335556">335556</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The commit \
https://projects.kde.org/projects/kde/kdelibs/repository/revisions/48dd1fc50277b861b49613c5f46b6f8b10cc932d \
introduced a bug: It factors out the code to convert a time specification to an \
actual time value into the function makeTimeFromList(). But in that function \
makeTime(&amp;t, ms, true) is called, whereas the original code called \
makeTime(&amp;t, ms, false) for the constructor.

This patch fixes it by passing the &quot;utc&quot; parameter to makeTime() instead of \
&quot;true&quot;.

Please note that this bug is also present in Frameworks5.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loaded the test case from the bug report into Konqueror/KHTML. The \
correct time is shown now like in other browsers, including Konqueror/WebKit.</pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kjs/date_object.cpp <span style="color: grey">(c8d776c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118947/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============1260841621984772103==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic