[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 118954: Set directory to current working directory when executing "Open With..." 
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2014-06-29 16:06:11
Message-ID: 20140629160611.21193.20071 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118954/
-----------------------------------------------------------

(Updated June 29, 2014, 4:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and David Faure.


Bugs: 142597
    http://bugs.kde.org/show_bug.cgi?id=142597


Repository: kdelibs


Description
-------

The attached patch sets the current directory to the current working directory (read: \
directory in which the open with dialog was run) whenever the KService path is empty. \
That way we tell KProcess in the context of the current directory instead of the \
default one it uses, $HOME.


Diffs
-----

  kinit/klauncher.cpp 6c71e99 
  kio/kio/krun.cpp 590fcf8 

Diff: https://git.reviewboard.kde.org/r/118954/diff/


Testing
-------

Tested with the example provided in the bug report. Verified the output of the \
compile process is in the current working directory instead of $HOME.


Thanks,

Dawit Alemayehu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118954/">https://git.reviewboard.kde.org/r/118954/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>


<p style="color: grey;"><i>Updated June 29, 2014, 4:06 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=142597">142597</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch sets the current directory to the current working \
directory (read: directory in which the open with dialog was run) whenever the \
KService path is empty. That way we tell KProcess in the context of the current \
directory instead of the default one it uses, $HOME.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with the example provided in the bug report. Verified the output \
of the compile process is in the current working directory instead of $HOME.</pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kinit/klauncher.cpp <span style="color: grey">(6c71e99)</span></li>

 <li>kio/kio/krun.cpp <span style="color: grey">(590fcf8)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118954/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic