[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 118947: KJS: treat specified time correctly as localtime when passed to the Date(
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2014-06-26 12:03:00
Message-ID: 20140626120300.25128.27107 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118947/
-----------------------------------------------------------
(Updated June 26, 2014, 12:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for kdelibs.
Bugs: 335556
http://bugs.kde.org/show_bug.cgi?id=335556
Repository: kdelibs
Description
-------
The commit https://projects.kde.org/projects/kde/kdelibs/repository/revisions/48dd1fc50277b861b49613c5f46b6f8b10cc932d \
introduced a bug: It factors out the code to convert a time specification \
to an actual time value into the function makeTimeFromList(). But in that \
function makeTime(&t, ms, true) is called, whereas the original code called \
makeTime(&t, ms, false) for the constructor.
This patch fixes it by passing the "utc" parameter to makeTime() instead of \
"true".
Please note that this bug is also present in Frameworks5.
Diffs
-----
kjs/date_object.cpp c8d776c
Diff: https://git.reviewboard.kde.org/r/118947/diff/
Testing
-------
Loaded the test case from the bug report into Konqueror/KHTML. The correct \
time is shown now like in other browsers, including Konqueror/WebKit.
Thanks,
Wolfgang Bauer
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118947/">https://git.reviewboard.kde.org/r/118947/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated June 26, 2014, 12:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=335556">335556</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The commit \
https://projects.kde.org/projects/kde/kdelibs/repository/revisions/48dd1fc50277b861b49613c5f46b6f8b10cc932d \
introduced a bug: It factors out the code to convert a time specification \
to an actual time value into the function makeTimeFromList(). But in that \
function makeTime(&t, ms, true) is called, whereas the original code \
called makeTime(&t, ms, false) for the constructor.
This patch fixes it by passing the "utc" parameter to makeTime() \
instead of "true".
Please note that this bug is also present in Frameworks5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Loaded the test case from the bug report into Konqueror/KHTML. \
The correct time is shown now like in other browsers, including \
Konqueror/WebKit.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kjs/date_object.cpp <span style="color: grey">(c8d776c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118947/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic