[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 118898: KGamma: Apply user setting at login/startup
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2014-06-24 10:58:49
Message-ID: 20140624105849.24601.78445 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118898/
-----------------------------------------------------------
(Updated June 24, 2014, 10:58 a.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace, KDE Graphics, Plasma, and Marcel Wiesweg.
Bugs: 218668
http://bugs.kde.org/show_bug.cgi?id=218668
Repository: kgamma
Description
-------
KGamma's saved user settings are not applied on startup/login. The user has \
to enter the KCM to apply them. This makes it rather useless, as not even \
saving the settings system-wide really works any more. (this requires an \
xorg.conf which normally doesn't exist nowadays)
This patch uses kcminit to apply these settings again on login. Apparently \
this has been forgotten when moving/porting kgamma to KDE4.
PS: As there seems to be no kgamma group and this is desktop-related, I \
decided to add the kde-workspace and plasma groups for review. I hope \
that's ok... ;)
Diffs
-----
kcmkgamma/kgamma.cpp 890ba99
kcmkgamma/kgamma.desktop 3d87513
Diff: https://git.reviewboard.kde.org/r/118898/diff/
Testing
-------
Set a gamma value in the KGamma KCM, logout/login (or reboot), Gamma value
gets set correctly.
If there's no kgammarc file (or it contains no actual gamma settings), the \
Gamma value is not changed. It stays at what is configured for X (or its \
default).
Thanks,
Wolfgang Bauer
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118898/">https://git.reviewboard.kde.org/r/118898/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kde-workspace, KDE Graphics, Plasma, and Marcel \
Wiesweg.</div> <div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated June 24, 2014, 10:58 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=218668">218668</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgamma
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KGamma's saved user settings are not applied on \
startup/login. The user has to enter the KCM to apply them. This makes it \
rather useless, as not even saving the settings system-wide really works \
any more. (this requires an xorg.conf which normally doesn't exist \
nowadays)
This patch uses kcminit to apply these settings again on login. Apparently \
this has been forgotten when moving/porting kgamma to KDE4.
PS: As there seems to be no kgamma group and this is desktop-related, I \
decided to add the kde-workspace and plasma groups for review. I hope \
that's ok... ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Set a gamma value in the KGamma KCM, logout/login (or reboot), \
Gamma value gets set correctly.
If there's no kgammarc file (or it contains no actual gamma settings), \
the Gamma value is not changed. It stays at what is configured for X (or \
its default). </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kcmkgamma/kgamma.cpp <span style="color: grey">(890ba99)</span></li>
<li>kcmkgamma/kgamma.desktop <span style="color: \
grey">(3d87513)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118898/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic