[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 118749: Prevent crashes caused by invalid access of Konqueror's URL edit widget
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2014-06-16 3:50:18
Message-ID: 20140616035018.3734.18166 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118749/
-----------------------------------------------------------
(Updated June 16, 2014, 3:50 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Base Apps and David Faure.
Bugs: 320500
http://bugs.kde.org/show_bug.cgi?id=320500
Repository: kde-baseapps
Description
-------
The attached patch is intended to prevent all crashes that are caused by invalid \
access of the QLineEdit in Konqueror's URL combobox.
Diffs
-----
konqueror/src/konqmainwindow.h 4ad4c4f
konqueror/src/konqmainwindow.cpp da8c82e
Diff: https://git.reviewboard.kde.org/r/118749/diff/
Testing
-------
Thanks,
Dawit Alemayehu
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118749/">https://git.reviewboard.kde.org/r/118749/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated June 16, 2014, 3:50 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=320500">320500</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch is intended to prevent all crashes that are caused by \
invalid access of the QLineEdit in Konqueror's URL combobox.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqmainwindow.h <span style="color: grey">(4ad4c4f)</span></li>
<li>konqueror/src/konqmainwindow.cpp <span style="color: grey">(da8c82e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118749/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic