[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 118563: kscreenlocker_greet: use SA_RESTART for signal handler
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2014-06-05 16:20:01
Message-ID: 20140605162001.32751.51562 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118563/
-----------------------------------------------------------
(Updated June 5, 2014, 4:20 p.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace.
Repository: kde-workspace
Description
-------
As discussed in https://git.reviewboard.kde.org/r/117091/. Not using the \
SA_RESTART flag might (in theory) cause the greeter to be aborted (because \
certain syscalls may be interrupted and fail with EINTR). SA_RESTART seems \
to be the BSD default and is used by "legacy" signal() by default in glibc \
2 and later as well, anyway.
Diffs
-----
ksmserver/screenlocker/greeter/main.cpp 4cac94c
Diff: https://git.reviewboard.kde.org/r/118563/diff/
Testing
-------
I'm using this myself for one month without any problems.
Thanks,
Wolfgang Bauer
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118563/">https://git.reviewboard.kde.org/r/118563/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated June 5, 2014, 4:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As discussed in https://git.reviewboard.kde.org/r/117091/. Not \
using the SA_RESTART flag might (in theory) cause the greeter to be aborted \
(because certain syscalls may be interrupted and fail with EINTR). \
SA_RESTART seems to be the BSD default and is used by "legacy" \
signal() by default in glibc 2 and later as well, anyway.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm using this myself for one month without any \
problems.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/main.cpp <span style="color: \
grey">(4cac94c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118563/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic