[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 118504: Fix libssh timeout type
From: "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date: 2014-06-04 17:50:18
Message-ID: 20140604175018.17694.59610 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118504/#review59225
-----------------------------------------------------------
It seems to make sense +1.
Isn't there a way to make sure this won't happen again or that it isn't happening in other places?
- Aleix Pol Gonzalez
On June 3, 2014, 4:51 p.m., Lutz Heermann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118504/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 4:51 p.m.)
>
>
> Review request for KDE Runtime.
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> While preparing the connection to a SFTP server kio_sftp puts the timeouts to
> libssh's ssh_options_set as pointers to int while libssh expects the them to
> be given as pointers to long. See:
>
> http://git.libssh.org/projects/libssh.git/tree/src/options.c#n587
> http://git.libssh.org/projects/libssh.git/tree/src/options.c#n601
>
> I could fix several unpredictable connection problems by kio_sftp with this
> patch.
>
>
> Diffs
> -----
>
> kioslave/sftp/kio_sftp.cpp 21cffac0e5892944ca6c5b74537ebc4b7fb4738e
>
> Diff: https://git.reviewboard.kde.org/r/118504/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lutz Heermann
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118504/">https://git.reviewboard.kde.org/r/118504/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems to make sense \
+1.
Isn't there a way to make sure this won't happen again or that it isn't \
happening in other places?</pre> <br />
<p>- Aleix Pol Gonzalez</p>
<br />
<p>On June 3rd, 2014, 4:51 p.m. UTC, Lutz Heermann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime.</div>
<div>By Lutz Heermann.</div>
<p style="color: grey;"><i>Updated June 3, 2014, 4:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While preparing the connection to a SFTP server kio_sftp puts the \
timeouts to libssh's ssh_options_set as pointers to int while libssh expects the \
them to be given as pointers to long. See:
http://git.libssh.org/projects/libssh.git/tree/src/options.c#n587
http://git.libssh.org/projects/libssh.git/tree/src/options.c#n601
I could fix several unpredictable connection problems by kio_sftp with this
patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/sftp/kio_sftp.cpp <span style="color: \
grey">(21cffac0e5892944ca6c5b74537ebc4b7fb4738e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118504/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic