[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 117779: fix crash when textureNode->texture() is null
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-04-26 6:22:52
Message-ID: 20140426062252.23578.15695 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56587
-----------------------------------------------------------
I'd rather not want to see us hide this crash. There is an underlying problem which \
needs a more proper fix. I recently hit this problem myself on one on my systems and \
a crash one can reproduce is as good as fixed ;-)
- Martin Gräßlin
On April 26, 2014, 12:51 a.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> -----------------------------------------------------------
>
> (Updated April 26, 2014, 12:51 a.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> fix crash when textureNode->texture() is null
>
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
>
>
> Diffs
> -----
>
> src/declarativeimports/core/windowthumbnail.cpp \
> 59255f75994adb96b30fb503c759b2e9110ab708
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
>
>
> Testing
> -------
>
> No longer crashes
>
>
> Thanks,
>
> Alexander Richardson
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117779/">https://git.reviewboard.kde.org/r/117779/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd rather not want \
to see us hide this crash. There is an underlying problem which needs a more proper \
fix. I recently hit this problem myself on one on my systems and a crash one can \
reproduce is as good as fixed ;-)</pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On April 26th, 2014, 12:51 a.m. CEST, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated April 26, 2014, 12:51 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fix crash when textureNode->texture() is null
I get this crash very frequently on my system. This is probably only fixing
the symptom and not the underlying issue, however at least plasma no longer
crashes every few minutes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No longer crashes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: \
grey">(59255f75994adb96b30fb503c759b2e9110ab708)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117779/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic