[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 117779: fix crash when textureNode->texture() is null
From: Thomas_Lübking <thomas.luebking () gmail ! com>
Date: 2014-04-25 21:44:25
Message-ID: 20140425214425.18037.55277 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117779/#review56577
-----------------------------------------------------------
src/declarativeimports/core/windowthumbnail.cpp
<https://git.reviewboard.kde.org/r/117779/#comment39469>
try before this call.
- Thomas Lübking
On April 25, 2014, 9:41 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117779/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 9:41 p.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> fix crash when textureNode->texture() is null
>
> I get this crash very frequently on my system. This is probably only fixing
> the symptom and not the underlying issue, however at least plasma no longer
> crashes every few minutes
>
>
> Diffs
> -----
>
> src/declarativeimports/core/windowthumbnail.cpp 59255f75994adb96b30fb503c759b2e9110ab708
>
> Diff: https://git.reviewboard.kde.org/r/117779/diff/
>
>
> Testing
> -------
>
> No longer crashes
>
>
> Thanks,
>
> Alexander Richardson
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117779/">https://git.reviewboard.kde.org/r/117779/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117779/diff/1/?file=268344#file268344line231" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/core/windowthumbnail.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
WindowThumbnail::iconToTexture(WindowTextureNode *textureNode)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">228</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">textureNode</span><span class="o">-></span><span \
class="n">texture</span><span class="p">()</span><span class="o">-></span><span \
class="n">bind</span><span class="p">();</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">231</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">textureNode</span><span class="o">-></span><span \
class="n">texture</span><span class="p">()</span><span class="o">-></span><span \
class="n">bind</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">try before \
this call.</pre> </div>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On April 25th, 2014, 9:41 p.m. UTC, Alexander Richardson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Alexander Richardson.</div>
<p style="color: grey;"><i>Updated April 25, 2014, 9:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">fix crash when textureNode->texture() is null
I get this crash very frequently on my system. This is probably only fixing
the symptom and not the underlying issue, however at least plasma no longer
crashes every few minutes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No longer crashes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/windowthumbnail.cpp <span style="color: \
grey">(59255f75994adb96b30fb503c759b2e9110ab708)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117779/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic