[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 117091: Force the screen locker's greeter to show the password input field in cas
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2014-04-24 22:20:10
Message-ID: 20140424222010.26065.18762 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117091/
-----------------------------------------------------------
(Updated April 24, 2014, 10:20 p.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace, Plasma and Aaron J. Seigo.
Bugs: 327947 and 329076
http://bugs.kde.org/show_bug.cgi?id=327947
http://bugs.kde.org/show_bug.cgi?id=329076
Repository: kde-workspace
Description
-------
If the screen locker is set to not require a password to unlock, it will \
not show the password input field even when the powermanagement settings \
suspend the system and are set to require a password after resume (when it \
was already running at that point). This locks people out of their system.
This patch adds a signal handler for SIGUSR1 that switches the running \
greeter to immediateLock mode. The locker sends that signal to make sure \
the greeter shows the password input field when necessary.
Diffs
-----
ksmserver/screenlocker/greeter/greeterapp.h 8b79188
ksmserver/screenlocker/greeter/greeterapp.cpp c5e2f85
ksmserver/screenlocker/greeter/main.cpp d898734
ksmserver/screenlocker/ksldapp.cpp 3dfcc9e
Diff: https://git.reviewboard.kde.org/r/117091/diff/
Testing
-------
Disable "Require password after" in the screen locker settings (the \
default), set it to start after 1 min. (for easier testing). Enable \
"Suspend session after" and set it to 2 minutes. (set the action to \
"Suspend", "Hibernate", or "Lock Screen", doesn't matter) Make sure "Lock \
screen on resume" is enabled in the powermanagements "Advanced Options" (it \
is by default).
After 1 minute the screen locker kicks in, and doesn't require a password.
After 2 minutes the session gets suspended, hibernated or locked, and \
requires a password to resume.
Without this patch no password dialog is shown, the user cannot resume the \
session by entering the password.
With this patch this works: there is a password input field, the session is \
unlocked when the user enters the password.
Thanks,
Wolfgang Bauer
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117091/">https://git.reviewboard.kde.org/r/117091/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px \
gray solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This \
change has been marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma and Aaron J. Seigo.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated April 24, 2014, 10:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=327947">327947</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=329076">329076</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If the screen locker is set to not require a password to \
unlock, it will not show the password input field even when the \
powermanagement settings suspend the system and are set to require a \
password after resume (when it was already running at that point). This \
locks people out of their system.
This patch adds a signal handler for SIGUSR1 that switches the running \
greeter to immediateLock mode. The locker sends that signal to make sure \
the greeter shows the password input field when necessary. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Disable "Require password after" in the screen \
locker settings (the default), set it to start after 1 min. (for easier \
testing). Enable "Suspend session after" and set it to 2 minutes. \
(set the action to "Suspend", "Hibernate", or \
"Lock Screen", doesn't matter) Make sure "Lock screen on \
resume" is enabled in the powermanagements "Advanced \
Options" (it is by default).
After 1 minute the screen locker kicks in, and doesn't require a \
password. After 2 minutes the session gets suspended, hibernated or locked, \
and requires a password to resume.
Without this patch no password dialog is shown, the user cannot resume the \
session by entering the password.
With this patch this works: there is a password input field, the session is \
unlocked when the user enters the password. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: \
grey">(8b79188)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(c5e2f85)</span></li>
<li>ksmserver/screenlocker/greeter/main.cpp <span style="color: \
grey">(d898734)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(3dfcc9e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117091/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic