From kde-core-devel Mon Apr 14 12:17:22 2014 From: "Kevin Krammer" Date: Mon, 14 Apr 2014 12:17:22 +0000 To: kde-core-devel Subject: Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string Message-Id: <20140414121722.31494.27220 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=139747787625652 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3574825968880345341==" --===============3574825968880345341== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/#review55705 ----------------------------------------------------------- Looks good to me, but maybe let dfaure have a second look - Kevin Krammer On April 14, 2014, 11:48 a.m., David Jarvie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116951/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 11:48 a.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. > > > Diffs > ----- > > kio/kio/kdbusservicestarter.cpp 90624fb > > Diff: https://git.reviewboard.kde.org/r/116951/diff/ > > > Testing > ------- > > Tested this scenario, and it now returns the error string. > > > Thanks, > > David Jarvie > > --===============3574825968880345341== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/

Looks good to me, but maybe let dfaure have a second look

- Kevin Krammer

On April 14th, 2014, 11:48 a.m. UTC, David Jarvie wrote:

Review request for kdelibs.

By David Jarvie.

Updated April 14, 2014, 11:48 a.m.

Repository: kdelibs

Description

When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.

Testing

Tested this scenario, and it now returns the error string.

Diffs

kio/kio/kdbusservicestarter.cpp (90624fb)

View Diff

--===============3574825968880345341==--