--===============9089976906802394834== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/#review55680 ----------------------------------------------------------- kio/kio/kdbusservicestarter.cpp indentation looks wrong but maybe that's the diff interface kio/kio/kdbusservicestarter.cpp same here - Kevin Krammer On April 13, 2014, 10:41 p.m., David Jarvie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116951/ > ----------------------------------------------------------- > > (Updated April 13, 2014, 10:41 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > ------- > > When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. > > > Diffs > ----- > > kio/kio/kdbusservicestarter.cpp 90624fb > > Diff: https://git.reviewboard.kde.org/r/116951/diff/ > > > Testing > ------- > > Tested this scenario, and it now returns the error string. > > > Thanks, > > David Jarvie > > --===============9089976906802394834== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/

kio/kio/kdbusservicestarter.cpp (Diff revision 4) 
int KDBusServiceStarter::findServiceFor( const QString& serviceType,
84 
        QString error;
 84 
	QString err;
 
indentation looks wrong but maybe that's the diff interface

kio/kio/kdbusservicestarter.cpp (Diff revision 4) 
int KDBusServiceStarter::findServiceFor( const QString& serviceType,
87 
            kDebug() << "Couldn't start service:" << error;
 87 
	    if ( error )
 
same here

- Kevin Krammer


On April 13th, 2014, 10:41 p.m. UTC, David Jarvie wrote:

Review request for kdelibs.
By David Jarvie.

Updated April 13, 2014, 10:41 p.m.

Repository: kdelibs

Description 

When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.

Testing 

Tested this scenario, and it now returns the error string.

Diffs

  • kio/kio/kdbusservicestarter.cpp (90624fb)

View Diff
--===============9089976906802394834==--