From kde-core-devel Sun Apr 13 22:41:45 2014 From: "David Jarvie" Date: Sun, 13 Apr 2014 22:41:45 +0000 To: kde-core-devel Subject: Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string Message-Id: <20140413224145.31494.41713 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=139742894317123 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0719350234577945136==" --===============0719350234577945136== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/ ----------------------------------------------------------- (Updated April 13, 2014, 10:41 p.m.) Review request for kdelibs. Changes ------- Always output error in debug message. Repository: kdelibs Description ------- When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox. Diffs (updated) ----- kio/kio/kdbusservicestarter.cpp 90624fb Diff: https://git.reviewboard.kde.org/r/116951/diff/ Testing ------- Tested this scenario, and it now returns the error string. Thanks, David Jarvie --===============0719350234577945136== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116951/

Review request for kdelibs.
By David Jarvie.

Updated April 13, 2014, 10:41 p.m.

Changes

Always output error in debug message.
Repository: kdelibs

Description 

When KDBusServiceStarter::findServiceFor() fails to start the requested service after it is found to not be running, it does not return the error string. This patch fixes that and makes it behave as in the apidox.

Testing 

Tested this scenario, and it now returns the error string.

Diffs (updated)

  • kio/kio/kdbusservicestarter.cpp (90624fb)

View Diff
--===============0719350234577945136==--