[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 116951: Fix KDBusServiceStarter::findServiceFor() not returning error string
From: "David Faure" <faure () kde ! org>
Date: 2014-04-11 23:23:22
Message-ID: 20140411232322.22682.17272 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116951/#review55480
-----------------------------------------------------------
kio/kio/kdbusservicestarter.cpp
<https://git.reviewboard.kde.org/r/116951/#comment38613>
This would hide the error from the debug string, if the caller didn't specify an \
error pointer.
Better use a local var (say localError) and then
if (error)
*error = localError;
- David Faure
On March 21, 2014, 3:10 p.m., David Jarvie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116951/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 3:10 p.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> When KDBusServiceStarter::findServiceFor() fails to start the requested service \
> after it is found to not be running, it does not return the error string. This \
> patch fixes that and makes it behave as in the apidox.
>
> Diffs
> -----
>
> kio/kio/kdbusservicestarter.cpp 90624fb
>
> Diff: https://git.reviewboard.kde.org/r/116951/diff/
>
>
> Testing
> -------
>
> Tested this scenario, and it now returns the error string.
>
>
> Thanks,
>
> David Jarvie
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116951/">https://git.reviewboard.kde.org/r/116951/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/116951/diff/3/?file=255930#file255930line87" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kio/kio/kdbusservicestarter.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
KDBusServiceStarter::findServiceFor( const QString& serviceType,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">87</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">kDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="s">"Couldn't start service:"</span> <span \
class="o"><<</span> <span class="n">error</span><span \
class="p">;</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">86</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">kDebug</span><span \
class="p">()</span> <span class="o"><<</span> <span \
class="s">"Couldn't start service<span class="hl">"</span></span><span \
class="hl"> </span><span class="o"><span class="hl"><<</span></span><span \
class="hl"> </span><span class="n"><span class="hl">serviceType</span></span><span \
class="hl"> </span><span class="o"><span class="hl"><<</span></span><span \
class="hl"> </span><span class="s"><span class="hl">"</span>:"</span> <span \
class="o"><<</span> <span class="p"><span class="hl">(</span></span><span \
class="n">error</span><span class="hl"> </span><span class="o"><span \
class="hl">?</span></span><span class="hl"> </span><span class="o"><span \
class="hl">*</span></span><span class="n"><span class="hl">error</span></span><span \
class="hl"> </span><span class="o"><span class="hl">:</span></span> <span \
class="hl"> </span><span class="n"><span class="hl">QString</span></span><span \
class="p"><span class="hl">())</span>;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This would \
hide the error from the debug string, if the caller didn't specify an error \
pointer.
Better use a local var (say localError) and then
if (error)
*error = localError;</pre>
</div>
<br />
<p>- David Faure</p>
<br />
<p>On March 21st, 2014, 3:10 p.m. UTC, David Jarvie wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By David Jarvie.</div>
<p style="color: grey;"><i>Updated March 21, 2014, 3:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When KDBusServiceStarter::findServiceFor() fails to start the requested \
service after it is found to not be running, it does not return the error string. \
This patch fixes that and makes it behave as in the apidox.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested this scenario, and it now returns the error string.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/kdbusservicestarter.cpp <span style="color: grey">(90624fb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116951/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic