[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 117174: Fix installing and removing desktop plasma theme packages.
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2014-03-31 16:04:08
Message-ID: 20140331160408.20889.51589 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117174/#review54702
-----------------------------------------------------------
plasma/packagestructure.cpp
<https://git.reviewboard.kde.org/r/117174/#comment38226>
{ go on the next line (here and elsewhere)
plasma/packagestructure.cpp
<https://git.reviewboard.kde.org/r/117174/#comment38225>
This is going to be funny if you have multiple packages in the path you're \
specifying here, it will rely on directory listing ordering then -- perhaps not what \
you want. If it's random anyway, why parse all, and not just pick the first one?
- Sebastian Kügler
On March 30, 2014, 1:14 p.m., Andrei Amuraritei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117174/
> -----------------------------------------------------------
>
> (Updated March 30, 2014, 1:14 p.m.)
>
>
> Review request for kdelibs, Albert Astals Cid, Aaron J. Seigo, David Faure, and Ian \
> Monroe.
>
> Bugs: 149479
> http://bugs.kde.org/show_bug.cgi?id=149479
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Even though the bug appears RESOLVED it is not.
>
> Minor hack to packagestructure.cpp to search for the metadata.desktop file \
> recursively. This helps with installing desktop themes and removing them. I have \
> tested this on kdelibs 4.13 compiled with kdesrc-build. When testing themes ignore \
> SoftSand for example, it's metadata.desktop is not properly formatted. There are \
> others too which are not formatted which I guess could be fixed by setting a new \
> format standard, maybe even a check package script to check new uploads on \
> kde-look.org.
>
> Diffs
> -----
>
> plasma/packagestructure.cpp 71148e1
>
> Diff: https://git.reviewboard.kde.org/r/117174/diff/
>
>
> Testing
> -------
>
> Compiled, run systemsettings, go to Desktop Themes, install / remove away. Some \
> themes are broken so they won't work (not install).
>
> Thanks,
>
> Andrei Amuraritei
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117174/">https://git.reviewboard.kde.org/r/117174/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117174/diff/2/?file=258228#file258228line653" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/packagestructure.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">PackageMetadata PackageStructure::metadata()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">653</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">while</span> <span class="p">(</span><span \
class="n">dirit</span><span class="p">.</span><span class="n">hasNext</span><span \
class="p">())</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">{ go on the \
next line (here and elsewhere)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117174/diff/2/?file=258228#file258228line659" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/packagestructure.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">PackageMetadata PackageStructure::metadata()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">659</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">d</span><span class="o">-></span><span \
class="n">createPackageMetadata</span><span class="p">(</span><span \
class="n">dirit</span><span class="p">.</span><span class="n">fileInfo</span><span \
class="p">().</span><span class="n">absolutePath</span><span \
class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is \
going to be funny if you have multiple packages in the path you're specifying \
here, it will rely on directory listing ordering then -- perhaps not what you want. \
If it's random anyway, why parse all, and not just pick the first one?</pre> \
</div> <br />
<p>- Sebastian Kügler</p>
<br />
<p>On March 30th, 2014, 1:14 p.m. UTC, Andrei Amuraritei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Albert Astals Cid, Aaron J. Seigo, David Faure, and \
Ian Monroe.</div> <div>By Andrei Amuraritei.</div>
<p style="color: grey;"><i>Updated March 30, 2014, 1:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=149479">149479</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Even though the bug appears RESOLVED it is not.
Minor hack to packagestructure.cpp to search for the metadata.desktop file \
recursively. This helps with installing desktop themes and removing them. I have \
tested this on kdelibs 4.13 compiled with kdesrc-build. When testing themes ignore \
SoftSand for example, it's metadata.desktop is not properly formatted. There are \
others too which are not formatted which I guess could be fixed by setting a new \
format standard, maybe even a check package script to check new uploads on \
kde-look.org.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, run systemsettings, go to Desktop Themes, install / remove \
away. Some themes are broken so they won't work (not install). </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/packagestructure.cpp <span style="color: grey">(71148e1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117174/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic