[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 116602: fix setting "ssl_was_in_use" metadata
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2014-03-27 4:32:40
Message-ID: 20140327043240.18781.80984 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116602/#review54260
-----------------------------------------------------------
Ship it!
In that case then you can ship it. I do not care about the other suggestion I made.
- Dawit Alemayehu
On March 4, 2014, 9:43 p.m., Andrea Iacovitti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116602/
> -----------------------------------------------------------
>
> (Updated March 4, 2014, 9:43 p.m.)
>
>
> Review request for kdelibs and Dawit Alemayehu.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> If incomingMetaData doesn't contain item with key "ssl_in_use" (and i verified this \
> happen) using [] operator results in inserting a new item with key "ssl_in_use" and \
> NullString value in incomingMetaData map and, as a consequence, a new item with key \
> "ssl_was_in_use" and NullString value in outgoingMetaData map. This patch aims to \
> avoid this situation by looking up the key using queryMetadata().
>
> Diffs
> -----
>
> kio/kio/job.cpp edc5fed
>
> Diff: https://git.reviewboard.kde.org/r/116602/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrea Iacovitti
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116602/">https://git.reviewboard.kde.org/r/116602/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In that case then you \
can ship it. I do not care about the other suggestion I made.</pre> <br />
<p>- Dawit Alemayehu</p>
<br />
<p>On March 4th, 2014, 9:43 p.m. UTC, Andrea Iacovitti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Dawit Alemayehu.</div>
<div>By Andrea Iacovitti.</div>
<p style="color: grey;"><i>Updated March 4, 2014, 9:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If incomingMetaData doesn't contain item with key \
"ssl_in_use" (and i verified this happen) using [] operator results in \
inserting a new item with key "ssl_in_use" and NullString value in \
incomingMetaData map and, as a consequence, a new item with key \
"ssl_was_in_use" and NullString value in outgoingMetaData map. This patch \
aims to avoid this situation by looking up the key using queryMetadata().</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/job.cpp <span style="color: grey">(edc5fed)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116602/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic