From kde-core-devel Fri Mar 14 11:06:38 2014 From: "Jaime Torres Amate" Date: Fri, 14 Mar 2014 11:06:38 +0000 To: kde-core-devel Subject: Re: Review Request 116097: No longer use strlcpy in kstartupconfig Message-Id: <20140314110638.2591.92983 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=139479522627768 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4248707847673207696==" --===============4248707847673207696== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116097/#review52934 ----------------------------------------------------------- It works for me (I get kstartupconfig5 built). If it works in WIN32, you have my ship it!. - Jaime Torres Amate On Feb. 26, 2014, 6:11 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116097/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2014, 6:11 p.m.) > > > Review request for kde-workspace. > > > Repository: kde-workspace > > > Description > ------- > > No longer use strlcpy in kstartupconfig > > This means we no longer need to find libbsd on Linux. > kstartupconfig is now uses std::string instead of pure C strings, but > the performance difference should be minimal (and it is less error-prone). > > > Diffs > ----- > > CMakeLists.txt bce3cd1de65b8420a859c342db981919965071ba > cmake/modules/FindLibBSD.cmake 6383083023cdbfbeffcab0cef98f48102e593d38 > kstartupconfig/CMakeLists.txt ceebd6a65af4cdaa717cfb0dcff5097121cf48d9 > kstartupconfig/kstartupconfig.c d8e65f48a75dad49fe6c585f89260c2a6d483809 > > Diff: https://git.reviewboard.kde.org/r/116097/diff/ > > > Testing > ------- > > compiles > > > Thanks, > > Alexander Richardson > > --===============4248707847673207696== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116097/

It works for me (I get kstartupconfig5 built). If it works in WIN32, you have my ship it!.

- Jaime Torres Amate

On February 26th, 2014, 6:11 p.m. UTC, Alexander Richardson wrote:

Review request for kde-workspace.

By Alexander Richardson.

Updated Feb. 26, 2014, 6:11 p.m.

Repository: kde-workspace

Description

No longer use strlcpy in kstartupconfig

This means we no longer need to find libbsd on Linux.
kstartupconfig is now uses std::string instead of pure C strings, but
the performance difference should be minimal (and it is less error-prone).

Testing

compiles

Diffs

CMakeLists.txt (bce3cd1de65b8420a859c342db981919965071ba)
cmake/modules/FindLibBSD.cmake (6383083023cdbfbeffcab0cef98f48102e593d38)
kstartupconfig/CMakeLists.txt (ceebd6a65af4cdaa717cfb0dcff5097121cf48d9)
kstartupconfig/kstartupconfig.c (d8e65f48a75dad49fe6c585f89260c2a6d483809)

View Diff

--===============4248707847673207696==--