[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 116783: Change ftpFileExists to use relative paths for SIZE requests
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2014-03-13 23:30:14
Message-ID: 20140313233014.14211.56022 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116783/
-----------------------------------------------------------

(Updated March 13, 2014, 11:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and David Faure.


Repository: kdelibs


Description
-------

I completely missed ftpFileExists issued a SIZE command to determine the existence of \
a file when addressing bug# 326292. See https://git.reviewboard.kde.org/r/116524/ \
review request. The attached patch addresses that oversight to insure renaming files \
work properly on the android ftp server listed in the bug report.


Diffs
-----

  kioslave/ftp/ftp.h cbcd096 
  kioslave/ftp/ftp.cpp b9d90e6 

Diff: https://git.reviewboard.kde.org/r/116783/diff/


Testing
-------

Rerun all the tests run for 116524.


Thanks,

Dawit Alemayehu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116783/">https://git.reviewboard.kde.org/r/116783/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs and David Faure.</div>
<div>By Dawit Alemayehu.</div>


<p style="color: grey;"><i>Updated March 13, 2014, 11:30 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I completely missed ftpFileExists issued a SIZE command to determine the \
existence of a file when addressing bug# 326292. See \
https://git.reviewboard.kde.org/r/116524/ review request. The attached patch \
addresses that oversight to insure renaming files work properly on the android ftp \
server listed in the bug report.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Rerun all the tests run for 116524.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/ftp/ftp.h <span style="color: grey">(cbcd096)</span></li>

 <li>kioslave/ftp/ftp.cpp <span style="color: grey">(b9d90e6)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116783/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic