[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 116784: Fix incorrect use of KDateTime.toTime_t in kio_http
From:       "Dawit Alemayehu" <adawit () kde ! org>
Date:       2014-03-13 12:49:21
Message-ID: 20140313124921.14211.70627 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116784/
-----------------------------------------------------------

Review request for kdelibs, Andreas Hartmetz and David Faure.


Repository: kdelibs


Description
-------

The attached patch does the following:

- It corrects a mistake in assumption that KDateTime.toTime_t() will return -1 for \
invalidate dates. It does not. The result is an overflow which is interpreted in \
kio_http as a timestamp in the distant future which obviously is wrong. See \
https://bugs.kde.org/show_bug.cgi?id=331774 for example. This assumption also affects \
the timestamp variables used for cache management.

- It converts cache management timestamp variables to 64 bits so they can accomodates \
dates beyond Feb 7, 2106.


Diffs
-----

  kioslave/http/http.h dd85622 
  kioslave/http/http.cpp e4f1eba 

Diff: https://git.reviewboard.kde.org/r/116784/diff/


Testing
-------


Thanks,

Dawit Alemayehu


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116784/">https://git.reviewboard.kde.org/r/116784/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs, Andreas Hartmetz and David Faure.</div>
<div>By Dawit Alemayehu.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached patch does the following:

- It corrects a mistake in assumption that KDateTime.toTime_t() will return -1 for \
invalidate dates. It does not. The result is an overflow which is interpreted in \
kio_http as a timestamp in the distant future which obviously is wrong. See \
https://bugs.kde.org/show_bug.cgi?id=331774 for example. This assumption also affects \
the timestamp variables used for cache management.

- It converts cache management timestamp variables to 64 bits so they can accomodates \
dates beyond Feb 7, 2106.</pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kioslave/http/http.h <span style="color: grey">(dd85622)</span></li>

 <li>kioslave/http/http.cpp <span style="color: grey">(e4f1eba)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116784/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic