[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 116122: Do not add trailing slash on http DELETE requests
From: "Andrea Iacovitti" <aiacovitti () libero ! it>
Date: 2014-03-08 12:40:07
Message-ID: 20140308124007.2613.74221 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/#review52381
-----------------------------------------------------------
I'm a bit lost with your latest patch uploaded...
Speaking about the third patch in this review (Diff r3) it seems it works as \
expected. That is if a server redirects a collection DELETE operation to a new \
Location with trailing slash added, redirection is correctly followed. From my part \
it is a ship for this one (Diff r3).
- Andrea Iacovitti
On March 7, 2014, 6:05 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116122/
> -----------------------------------------------------------
>
> (Updated March 7, 2014, 6:05 a.m.)
>
>
> Review request for kdelibs, Andrea Iacovitti and David Faure.
>
>
> Bugs: 331295
> http://bugs.kde.org/show_bug.cgi?id=331295
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, which \
> attempted to workaround webdav servers that do not accept delete requests on \
> directories unless there is a trailing slash. It ensures that the "fix" is only \
> applicable to webdav and the addition of the trailing slash is communicated to the \
> client application.
>
> Diffs
> -----
>
> kioslave/http/http.cpp 9eba5d1
>
> Diff: https://git.reviewboard.kde.org/r/116122/diff/
>
>
> Testing
> -------
>
> For HTTP delete:
> http://greenbytes.de/tech/tc/httpredirects/t301methods.html
>
> For WebDAV delete:
> http://boonfaya.com/sites/webdavapps.com/#targets
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116122/">https://git.reviewboard.kde.org/r/116122/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm a bit lost with \
your latest patch uploaded...
Speaking about the third patch in this review (Diff r3) it seems it works as \
expected. That is if a server redirects a collection DELETE operation to a new \
Location with trailing slash added, redirection is correctly followed. From my part \
it is a ship for this one (Diff r3).</pre> <br />
<p>- Andrea Iacovitti</p>
<br />
<p>On March 7th, 2014, 6:05 a.m. UTC, Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Andrea Iacovitti and David Faure.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated March 7, 2014, 6:05 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=331295">331295</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes a prior commit, http://commits.kde.org/kdelibs/58294ac, \
which attempted to workaround webdav servers that do not accept delete requests on \
directories unless there is a trailing slash. It ensures that the "fix" is \
only applicable to webdav and the addition of the trailing slash is communicated to \
the client application.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For HTTP delete: \
http://greenbytes.de/tech/tc/httpredirects/t301methods.html
For WebDAV delete:
http://boonfaya.com/sites/webdavapps.com/#targets</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/http/http.cpp <span style="color: grey">(9eba5d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116122/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic