From kde-core-devel Fri Mar 07 06:48:31 2014 From: "Dawit Alemayehu" Date: Fri, 07 Mar 2014 06:48:31 +0000 To: kde-core-devel Subject: Re: Review Request 116524: Make kio_ftp work with ftp server that don't support absolute path with S Message-Id: <20140307064831.2613.57678 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=139417493031350 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3882516345233868704==" --===============3882516345233868704== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/ ----------------------------------------------------------- (Updated March 7, 2014, 6:48 a.m.) Review request for kdelibs and David Faure. Changes ------- Updated patch: - Try to always do SIZE requests using relative paths. - Removed changes a related bug report from this patch. Bugs: 326292 http://bugs.kde.org/show_bug.cgi?id=326292 Repository: kdelibs Description ------- This patch changes Ftp::ftpSize such that it has support for servers that do not allow absolute paths with the SIZE command. That means when sending the command "SIZE /somefile" fails, it will try sending "SIZE somefile" before giving up. See bug report for details. Diffs (updated) ----- kioslave/ftp/ftp.cpp ddc6eaf Diff: https://git.reviewboard.kde.org/r/116524/diff/ Testing ------- Installed Ftp server from bug report on an Android device and run tests. Thanks, Dawit Alemayehu --===============3882516345233868704== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116524/

Review request for kdelibs and David Faure.

By Dawit Alemayehu.

Updated March 7, 2014, 6:48 a.m.

Changes

Updated patch:

- Try to always do SIZE requests using relative paths.
- Removed changes a related bug report from this patch.

Bugs: 326292

Repository: kdelibs

Description

This patch changes Ftp::ftpSize such that it has support for servers that do not allow absolute paths with the SIZE command. That means when sending the command "SIZE /somefile" fails, it will try sending "SIZE somefile" before giving up. See bug report for details.

Testing

Installed Ftp server from bug report on an Android device and run tests.

Diffs (updated)

kioslave/ftp/ftp.cpp (ddc6eaf)

View Diff

--===============3882516345233868704==--