[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 115864: kio_http: fixes for 30X response code redirection handling
From: "Andrea Iacovitti" <aiacovitti () libero ! it>
Date: 2014-02-20 11:28:44
Message-ID: 20140220112844.5175.52781 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115864/
-----------------------------------------------------------
(Updated Feb. 20, 2014, 11:28 a.m.)
Status
------
This change has been marked as submitted.
Review request for kdelibs and Dawit Alemayehu.
Repository: kdelibs
Description
-------
Check if method has been overridden via "CustomHTTPMethod" metaData when redirecting \
POST to GET in case of 301/302 response code. Handle "308 Permanent Redirect" \
response code.
Diffs
-----
kioslave/http/http.h 076ad2b
kioslave/http/http.cpp 68b5247
kioslave/http/httpauthentication.cpp 80d7995
Diff: https://git.reviewboard.kde.org/r/115864/diff/
Testing
-------
Thanks,
Andrea Iacovitti
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115864/">https://git.reviewboard.kde.org/r/115864/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Dawit Alemayehu.</div>
<div>By Andrea Iacovitti.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2014, 11:28 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Check if method has been overridden via "CustomHTTPMethod" \
metaData when redirecting POST to GET in case of 301/302 response code. Handle \
"308 Permanent Redirect" response code.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/http/http.h <span style="color: grey">(076ad2b)</span></li>
<li>kioslave/http/http.cpp <span style="color: grey">(68b5247)</span></li>
<li>kioslave/http/httpauthentication.cpp <span style="color: \
grey">(80d7995)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115864/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic