[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 115183: KRunner: reset history when showing (to be consistent with shells)
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2014-02-15 9:21:32
Message-ID: 20140215092132.11774.16542 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115183/
-----------------------------------------------------------
(Updated Feb. 15, 2014, 9:21 a.m.)
Status
------
This change has been marked as submitted.
Review request for kde-workspace.
Bugs: 314690
http://bugs.kde.org/show_bug.cgi?id=314690
Repository: kde-workspace
Description
-------
The referenced bug describes a recent change in the KRunner command history which \
makes recalling previous commands confusing, and different to the way that history \
recall works in Bash and other shells. I don't know whether this change was \
deliberate or accidental, but in the interests of consistency this patch ensures that \
the command history is reset to the beginning when showing the runner.
Diffs
-----
krunner/interfaces/default/interface.cpp 505e0aa
Diff: https://git.reviewboard.kde.org/r/115183/diff/
Testing
-------
Built kde-workspace with this change, verified operation of runner history. Also \
verified by another bug reporter.
Thanks,
Jonathan Marten
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115183/">https://git.reviewboard.kde.org/r/115183/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2014, 9:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314690">314690</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The referenced bug describes a recent change in the KRunner command \
history which makes recalling previous commands confusing, and different to the way \
that history recall works in Bash and other shells. I don't know whether this \
change was deliberate or accidental, but in the interests of consistency this patch \
ensures that the command history is reset to the beginning when showing the \
runner.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-workspace with this change, verified operation of runner \
history. Also verified by another bug reporter. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/interfaces/default/interface.cpp <span style="color: \
grey">(505e0aa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115183/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic