[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 115250: Try PASV mode when using Socks proxy
From: "Dawit Alemayehu" <adawit () kde ! org>
Date: 2014-02-11 0:35:28
Message-ID: 20140211003528.2474.74947 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115250/#review49496
-----------------------------------------------------------
Ship it!
Ship It!
- Dawit Alemayehu
On Jan. 23, 2014, 11:31 a.m., Emil Sedgh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115250/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2014, 11:31 a.m.)
>
>
> Review request for kdelibs, Dawit Alemayehu and David Faure.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> FTP has two modes: PASV and EPSV.
> Not all server's support EPSV.
>
> Currently, kio_ftp gives up on PASV mode if socks proxy is enabled.
> That is because QHostAddress.protocol() returns -1 (unknown protocol) on \
> KUrl("socks://localhost:3128").
> So kio_ftp fails using SOCKS proxy on server's that lack EPSV support.
>
> This patch makes sure kio_ftp will try PASV mode if socks proxy is enabled.
>
>
> Diffs
> -----
>
> kioslave/ftp/ftp.cpp 5bb2e8d
>
> Diff: https://git.reviewboard.kde.org/r/115250/diff/
>
>
> Testing
> -------
>
> Tested a server that lacks EPSV support with and without proxy.
> Seems fine now.
> Used to throw 'Internal Server error'.
>
>
> Thanks,
>
> Emil Sedgh
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115250/">https://git.reviewboard.kde.org/r/115250/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Dawit Alemayehu</p>
<br />
<p>On January 23rd, 2014, 11:31 a.m. UTC, Emil Sedgh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Dawit Alemayehu and David Faure.</div>
<div>By Emil Sedgh.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2014, 11:31 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">FTP has two modes: PASV and EPSV. Not all server's support EPSV.
Currently, kio_ftp gives up on PASV mode if socks proxy is enabled.
That is because QHostAddress.protocol() returns -1 (unknown protocol) on \
KUrl("socks://localhost:3128").
So kio_ftp fails using SOCKS proxy on server's that lack EPSV support.
This patch makes sure kio_ftp will try PASV mode if socks proxy is enabled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested a server that lacks EPSV support with and without proxy. Seems \
fine now. Used to throw 'Internal Server error'.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/ftp/ftp.cpp <span style="color: grey">(5bb2e8d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115250/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic