'Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 115497: Replace SHA with PBKDF2-SHA512+Salt
From:       Àlex_Fiestas <afiestas () kde ! org>
Date:       2014-02-10 17:43:46
Message-ID: 20140210174346.2474.52947 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115497/
-----------------------------------------------------------

(Updated Feb. 10, 2014, 5:43 p.m.)


Review request for KDE Runtime, Teo Mrnjavac and Valentin Rusu.


Repository: kde-runtime


Description
-------

Uses the MINOR_VERSION (which until now it was 0) to upgrade the hash from SHA to PBKDF2-SHA512+salt.
I would have loved to completely replace it once the wallet is ported to the new hashing but because
of kwalletd code that is not possible without a bigger rewrite.

There are 2 reasons for this patch:
1-We avoid using our own implementation of SHA
2-We use a modern hashing technique

I'm cooking more patches to use the system user password to open the wallet, we want that password to be
hashed using PBKDF2_SHA512 for security reasons.


Diffs (updated)
-----

  CMakeLists.txt 275a6c7 
  cmake/modules/FindLibGcrypt.cmake PRE-CREATION 
  kwalletd/backend/CMakeLists.txt 5a5837c 
  kwalletd/backend/backendpersisthandler.cpp bdef6ca 
  kwalletd/backend/kwalletbackend.h 83ebf7f 
  kwalletd/backend/kwalletbackend.cc e4d461c 

Diff: https://git.reviewboard.kde.org/r/115497/diff/


Testing
-------


Thanks,

Àlex Fiestas


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115497/">https://git.reviewboard.kde.org/r/115497/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Runtime, Teo Mrnjavac and Valentin Rusu.</div>
<div>By Àlex Fiestas.</div>


<p style="color: grey;"><i>Updated Feb. 10, 2014, 5:43 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Uses the MINOR_VERSION (which until now it was 0) to upgrade the hash \
from SHA to PBKDF2-SHA512+salt. I would have loved to completely replace it once the \
wallet is ported to the new hashing but because of kwalletd code that is not possible \
without a bigger rewrite.

There are 2 reasons for this patch:
1-We avoid using our own implementation of SHA
2-We use a modern hashing technique

I&#39;m cooking more patches to use the system user password to open the wallet, we \
want that password to be hashed using PBKDF2_SHA512 for security reasons.</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(275a6c7)</span></li>

 <li>cmake/modules/FindLibGcrypt.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>kwalletd/backend/CMakeLists.txt <span style="color: grey">(5a5837c)</span></li>

 <li>kwalletd/backend/backendpersisthandler.cpp <span style="color: \
grey">(bdef6ca)</span></li>

 <li>kwalletd/backend/kwalletbackend.h <span style="color: \
grey">(83ebf7f)</span></li>

 <li>kwalletd/backend/kwalletbackend.cc <span style="color: \
grey">(e4d461c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115497/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic