[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Moving Baloo and Baloo-widgets into KDE SC
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2014-01-19 14:56:17
Message-ID: CAGeFrHDPu6hsY_dN36FtZPD-f8pf7eBxS72zpimWMF+SsGvBqw () mail ! gmail ! com
[Download RAW message or body]

Code Review of baloo/file/lib

==file.cpp

Should it override type() from Item and set it to "File" ?


==filemodifyjob.cpp.

The code won't unset a rating, comments or tags on multiple files.
You update Xapian ok, but you're not calling fsetxattr().

The d  pointer leaks?

==DB.cpp
SQLITE3-> SQLITE

==general

Are you planning on putting all the Xapian queries in a new thread in
the future? If not having a KJob API doesn't have any benefit does it?

I would suggest you namespace your header guards
i.e
#ifndef FILE_H -> #ifndef BALOO_FILE_H
The current ones are very generic, it will be very easy to accidentally clash.

David


David
[prev in list] [next in list] [prev in thread] [next in thread]