'Re: Review Request 114455: kjs: Implement ES6 Math.imul'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 114455: kjs: Implement ES6 Math.imul
From:       "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date:       2014-01-16 17:56:31
Message-ID: 20140116175631.18276.99869 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114455/
-----------------------------------------------------------

(Updated Jan. 16, 2014, 5:56 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs.


Repository: kdelibs


Description
-------

kjs: Implement ES6 Math.imul

I admit I am totally lost here, I need help, the specs just confuse me. The code \
doesn't look like it does anything useful.

step 1 to 4 is just getting the values.
a and b must be a uint32_t.

5. Let product be (a * b) modulo 2^32.
6. If product ? 2^31, return product - 2^32, otherwise return product.

(Taken from ES6 draft 08.11.2013)

This is the part I don't understand at all.
I am not even sure about the product datatype.

Also NOTE: the JSC and firefox implementation look totally different and both return \
different values in highvalue cases, so I rather not trust them.


Diffs
-----

  kjs/math_object.h 3d193dd 
  kjs/math_object.cpp 89835e5 

Diff: https://git.reviewboard.kde.org/r/114455/diff/


Testing
-------


Thanks,

Bernd Buschinski


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114455/">https://git.reviewboard.kde.org/r/114455/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>


<p style="color: grey;"><i>Updated Jan. 16, 2014, 5:56 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs: Implement ES6 Math.imul

I admit I am totally lost here, I need help, the specs just confuse me. The code \
doesn&#39;t look like it does anything useful.

step 1 to 4 is just getting the values.
a and b must be a uint32_t.

5. Let product be (a * b) modulo 2^32.
6. If product ? 2^31, return product - 2^32, otherwise return product.

(Taken from ES6 draft 08.11.2013)

This is the part I don&#39;t understand at all.
I am not even sure about the product datatype.

Also NOTE: the JSC and firefox implementation look totally different and both return \
different values in highvalue cases, so I rather not trust them.</pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kjs/math_object.h <span style="color: grey">(3d193dd)</span></li>

 <li>kjs/math_object.cpp <span style="color: grey">(89835e5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114455/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic