[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 114686: Do not use a standard shortcut for KMessageWidget's "close" action
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2014-01-14 8:05:43
Message-ID: 20140114080543.30264.47411 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114686/#review47356
-----------------------------------------------------------
Ship it!
Makes sense to me, go for it.
- Aurélien Gâteau
On Dec. 27, 2013, 6:29 p.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114686/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2013, 6:29 p.m.)
>
>
> Review request for kdelibs and Aurélien Gâteau.
>
>
> Bugs: 317306
> http://bugs.kde.org/show_bug.cgi?id=317306
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> KMessageWidget uses KStandardAction::close() to create its "close" action. This \
> automatically sets Ctrl+W as the shortcut for that action. Unfortunately, this \
> shortcut may conflict with application-specific shortcuts. E.g., Dolphin uses \
> Ctrl+W for closing tabs, which means that the user will get an annoying "shortcut \
> conflict" error message if Ctrl+W is pressed while multiple tabs are open, and the \
> current tab has a message shown in a KMessageWidget.
> I propose to solve this problem by not using a default shortcut for \
> KMessageWidget's "close" action. I'd prefer to change this in master only to \
> prevent causing trouble for people who might rely on the current behavior.
>
> Diffs
> -----
>
> kdeui/widgets/kmessagewidget.cpp e5143cc
>
> Diff: https://git.reviewboard.kde.org/r/114686/diff/
>
>
> Testing
> -------
>
> I don't get a dialog showing the "Ambiguous shortcut" message any more in the \
> described use case.
>
> Thanks,
>
> Frank Reininghaus
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114686/">https://git.reviewboard.kde.org/r/114686/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes sense to me, go \
for it.</pre> <br />
<p>- Aurélien Gâteau</p>
<br />
<p>On December 27th, 2013, 6:29 p.m. CET, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs and Aurélien Gâteau.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2013, 6:29 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=317306">317306</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KMessageWidget uses KStandardAction::close() to create its \
"close" action. This automatically sets Ctrl+W as the shortcut for that \
action. Unfortunately, this shortcut may conflict with application-specific \
shortcuts. E.g., Dolphin uses Ctrl+W for closing tabs, which means that the user will \
get an annoying "shortcut conflict" error message if Ctrl+W is pressed \
while multiple tabs are open, and the current tab has a message shown in a \
KMessageWidget.
I propose to solve this problem by not using a default shortcut for \
KMessageWidget's "close" action. I'd prefer to change this in \
master only to prevent causing trouble for people who might rely on the current \
behavior.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I don't get a dialog showing the "Ambiguous shortcut" \
message any more in the described use case.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/widgets/kmessagewidget.cpp <span style="color: grey">(e5143cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114686/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic