[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110388: Change default thumbnail cache directory
From: "Maarten De Meyer" <de.meyer.maarten () gmail ! com>
Date: 2014-01-11 15:15:19
Message-ID: 20140111151519.7621.56974 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110388/
-----------------------------------------------------------
(Updated Jan. 11, 2014, 3:15 p.m.)
Status
------
This change has been discarded.
Review request for kdelibs.
Bugs: 319528
http://bugs.kde.org/show_bug.cgi?id=319528
Repository: kdelibs
Description
-------
The freedesktop spec[0] has changed the default location of the thumbnail cache \
directory. Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails instead of \
~/.thumbnails/ GNOME has already made this change.
Some applications[1] and documentation[2] (maybe thumbnailers) will have to be \
changed to adapt to this new directory. If this patch is accepted I'll make the \
needed changes. For frameworks we can use QStandardPaths::CacheLocation, I'll post a \
separate review for that.
All thumbnails will have to be regenerated. We could symlink the directory?
Is fromLocal8Bit correct or is UTF8 needed now?
[0] http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html
[1] configurepreviewdialog.cpp in Dolphin
[2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails
Diffs
-----
kio/kio/previewjob.cpp 01b674d
Diff: https://git.reviewboard.kde.org/r/110388/diff/
Testing
-------
Remove ~/.thumbnails/
Run dolphin with previews: thumbnails are created in .cache/thumbnails/
Repeated with XDG_CACHE_HOME=~/.cachetestdir/
Thumbnails in .cachetestdir/thumbnails/
Not tested: gwenview and digikam.
Thanks,
Maarten De Meyer
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110388/">https://git.reviewboard.kde.org/r/110388/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Maarten De Meyer.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2014, 3:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319528">319528</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The freedesktop spec[0] has changed the default location of the \
thumbnail cache directory. Now thumbnails are saved in $XDG_CACHE_HOME/thumbnails \
instead of ~/.thumbnails/ GNOME has already made this change.
Some applications[1] and documentation[2] (maybe thumbnailers) will have to be \
changed to adapt to this new directory. If this patch is accepted I'll make the \
needed changes. For frameworks we can use QStandardPaths::CacheLocation, I'll \
post a separate review for that.
All thumbnails will have to be regenerated. We could symlink the directory?
Is fromLocal8Bit correct or is UTF8 needed now?
[0] http://specifications.freedesktop.org/thumbnail-spec/thumbnail-spec-latest.html
[1] configurepreviewdialog.cpp in Dolphin
[2]http://techbase.kde.org/KDE_System_Administration/XDG_Filesystem_Hierarchy#Thumbnails</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove ~/.thumbnails/ Run dolphin with previews: thumbnails are created \
in .cache/thumbnails/
Repeated with XDG_CACHE_HOME=~/.cachetestdir/
Thumbnails in .cachetestdir/thumbnails/
Not tested: gwenview and digikam.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kio/previewjob.cpp <span style="color: grey">(01b674d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110388/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic