[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 114924: Konqueror: fix crash wnen switching between view modes
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2014-01-09 15:41:07
Message-ID: 20140109154107.28120.96484 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114924/
-----------------------------------------------------------
(Updated Jan. 9, 2014, 3:41 p.m.)
Status
------
This change has been discarded.
Review request for KDE Base Apps and Dawit Alemayehu.
Bugs: 322686
http://bugs.kde.org/show_bug.cgi?id=322686
Repository: kde-baseapps
Description
-------
The referenced bug describes an assert crash which happens when switching view modes \
in Konqueror, using the View - View Mode menu. It does not happen when switching \
view modes via the Dolphin Part toolbar.
Although the problem does not happen for adawit, this changes fixes the crash for me.
Diffs
-----
konqueror/src/konqmainwindow.cpp 8a21c1b
Diff: https://git.reviewboard.kde.org/r/114924/diff/
Testing
-------
Built kde-baseapps with these changes. Checked no crash when switching view mode \
both by toolbar and menu, and that the correct items in each case are checked.
Thanks,
Jonathan Marten
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114924/">https://git.reviewboard.kde.org/r/114924/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and Dawit Alemayehu.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2014, 3:41 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=322686">322686</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The referenced bug describes an assert crash which happens when \
switching view modes in Konqueror, using the View - View Mode menu. It does not \
happen when switching view modes via the Dolphin Part toolbar.
Although the problem does not happen for adawit, this changes fixes the crash for me.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-baseapps with these changes. Checked no crash when switching \
view mode both by toolbar and menu, and that the correct items in each case are \
checked. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>konqueror/src/konqmainwindow.cpp <span style="color: grey">(8a21c1b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114924/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic