[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 110813: Add support for just smooth window movement and resizing to wobbly window
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2014-01-08 12:00:34
Message-ID: 20140108120034.28120.98364 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110813/#review47043
-----------------------------------------------------------
sorry for the late review. It didn't end in my review board inbox :-(
I think it's conceptually wrong to have a no wobble option in an effect \
which is called wobbly windows. If one doesn't want wobbly windows one can \
just disable the effect. I understand what you want to achieve but adding \
it here makes the effect significantly more complex and adds a very obscure \
feature to the effect. I doubt that any users would find this feature and \
thus it would be a solution just for your private use case. We try to not \
go this road.
I thank you for this contribution and hope that you understand my reasoning \
why I don't want this in wobbly windows. Please excuse again the long time \
for the review.
- Martin Gräßlin
On June 3, 2013, 9:55 p.m., Stefanos Harhalakis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110813/
> -----------------------------------------------------------
>
> (Updated June 3, 2013, 9:55 p.m.)
>
>
> Review request for kde-workspace.
>
>
> Bugs: 319887
> http://bugs.kde.org/show_bug.cgi?id=319887
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> A patch that adds the ability to the wobbly windows effect not to wobble \
> the window (i.e. not change its shape).
> This results in two things:
> 1) Have a very smooth movement of windows that can be customized
> 2) Have a nice effect when resizing a window (is resizing is enabled)
>
> It does this by adding the noWobble attribute to the effect and then \
> using that attribute to disable a subset of the functionality. It also \
> adds an additional wobbliness level: shifts levels 0-4 to 1-5 and makes 0 \
> the level without wobbliness.
>
> Diffs
> -----
>
> kwin/effects/wobblywindows/wobblywindows.h 69d1f87
> kwin/effects/wobblywindows/wobblywindows.cpp ad1842c
> kwin/effects/wobblywindows/wobblywindows_config.ui 0498a64
>
> Diff: https://git.reviewboard.kde.org/r/110813/diff/
>
>
> Testing
> -------
>
> I'm running this for the past day without issues.
>
>
> Thanks,
>
> Stefanos Harhalakis
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110813/">https://git.reviewboard.kde.org/r/110813/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">sorry for the late review. It didn't end in my review \
board inbox :-(
I think it's conceptually wrong to have a no wobble option in an effect \
which is called wobbly windows. If one doesn't want wobbly windows one \
can just disable the effect. I understand what you want to achieve but \
adding it here makes the effect significantly more complex and adds a very \
obscure feature to the effect. I doubt that any users would find this \
feature and thus it would be a solution just for your private use case. We \
try to not go this road.
I thank you for this contribution and hope that you understand my reasoning \
why I don't want this in wobbly windows. Please excuse again the long \
time for the review.</pre> <br />
<p>- Martin Gräßlin</p>
<br />
<p>On June 3rd, 2013, 9:55 p.m. CEST, Stefanos Harhalakis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kde-workspace.</div>
<div>By Stefanos Harhalakis.</div>
<p style="color: grey;"><i>Updated June 3, 2013, 9:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319887">319887</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A patch that adds the ability to the wobbly windows effect not \
to wobble the window (i.e. not change its shape).
This results in two things:
1) Have a very smooth movement of windows that can be customized
2) Have a nice effect when resizing a window (is resizing is enabled)
It does this by adding the noWobble attribute to the effect and then using \
that attribute to disable a subset of the functionality. It also adds an \
additional wobbliness level: shifts levels 0-4 to 1-5 and makes 0 the level \
without wobbliness.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I'm running this for the past day without issues.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/effects/wobblywindows/wobblywindows.h <span style="color: \
grey">(69d1f87)</span></li>
<li>kwin/effects/wobblywindows/wobblywindows.cpp <span style="color: \
grey">(ad1842c)</span></li>
<li>kwin/effects/wobblywindows/wobblywindows_config.ui <span style="color: \
grey">(0498a64)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110813/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic