[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)"
From: "Commit Hook" <null () kde ! org>
Date: 2014-01-08 10:43:06
Message-ID: 20140108104306.28120.15724 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114889/#review47040
-----------------------------------------------------------
This review has been submitted with commit \
149fd780c71b3d8d3d4098f43f6cb746a3ef6ada by Friedrich W. H. Kossebau to \
branch master.
- Commit Hook
On Jan. 7, 2014, 4:24 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114889/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2014, 4:24 p.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kio
>
>
> Description
> -------
>
> Seems the code behind i18n() in kf5 does not like %-placeholders without \
> any arguments passed in the i18n call. And thus inserts the warning. \
> (Effect can be seen e.g. in Okteta's File Info tool).
> Attached patch fixes that, by passing as argument a string with an \
> argument placeholder again.
>
> Diffs
> -----
>
> src/core/global.cpp 42f453b
>
> Diff: https://git.reviewboard.kde.org/r/114889/diff/
>
>
> Testing
> -------
>
> Results of KIO::convertSize(...) displays fine in Okteta with the patch.
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114889/">https://git.reviewboard.kde.org/r/114889/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
149fd780c71b3d8d3d4098f43f6cb746a3ef6ada by Friedrich W. H. Kossebau to \
branch master.</pre> <br />
<p>- Commit Hook</p>
<br />
<p>On January 7th, 2014, 4:24 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2014, 4:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Seems the code behind i18n() in kf5 does not like \
%-placeholders without any arguments passed in the i18n call. And thus \
inserts the warning. (Effect can be seen e.g. in Okteta's File Info \
tool).
Attached patch fixes that, by passing as argument a string with an argument \
placeholder again.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Results of KIO::convertSize(...) displays fine in Okteta with \
the patch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/global.cpp <span style="color: grey">(42f453b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114889/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic