'Review Request 114907: Make KFontUtils::adaptFontSize be a bit more exact'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Review Request 114907: Make KFontUtils::adaptFontSize be a bit more exact
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2014-01-07 22:36:00
Message-ID: 20140107223600.16659.15582 () probe ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114907/
-----------------------------------------------------------

Review request for kdelibs and Jeremy Whiting.


Repository: kdelibs


Description
-------

Not all fonts are linear in drawn size against their point size, the old \
code assumes so and simply guesses the next font size taking into account \
the pointSize we drawn, the geometry we got and the geometry we want. The \
new code is a bit slower but will make sure that we get better pointSize \
results in non linear fonts.


Diffs
-----

  kdeui/fonts/kfontutils.cpp 3a80039 

Diff: https://git.reviewboard.kde.org/r/114907/diff/


Testing
-------

Blinken still works. Font sizes are similar.


Thanks,

Albert Astals Cid


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114907/">https://git.reviewboard.kde.org/r/114907/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for kdelibs and Jeremy Whiting.</div>
<div>By Albert Astals Cid.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Not all fonts are linear in drawn size against their point \
size, the old code assumes so and simply guesses the next font size taking \
into account the pointSize we drawn, the geometry we got and the geometry \
we want. The new code is a bit slower but will make sure that we get better \
pointSize results in non linear fonts.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Blinken still works. Font sizes are similar.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>kdeui/fonts/kfontutils.cpp <span style="color: \
grey">(3a80039)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114907/diff/" \
style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]
Configure | About | News | Add a list | Sponsored by KoreLogic