From kde-core-devel Tue Jan 07 08:51:55 2014 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Tue, 07 Jan 2014 08:51:55 +0000 To: kde-core-devel Subject: Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse Message-Id: <20140107085155.7621.62188 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=138908474532670 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4183750637587014844==" --===============4183750637587014844== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review46960 ----------------------------------------------------------- how does that behave with the normal locker (that is no screensaver)? - Martin Gräßlin On Jan. 5, 2014, 9:55 a.m., Wolfgang Bauer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114841/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2014, 9:55 a.m.) > > > Review request for kde-workspace and Martin Gräßlin. > > > Bugs: 311571 and 316459 > http://bugs.kde.org/show_bug.cgi?id=311571 > http://bugs.kde.org/show_bug.cgi?id=316459 > > > Repository: kde-workspace > > > Description > ------- > > Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the Screen savers from blanking the mouse cursor. > > I don't know why this has been done in the first place, but I couldn't see any negative effect by setting it to None. Now the mouse cursor even changes to the IBeam again when over the password field, which I find more intuitive. > > > Diffs > ----- > > ksmserver/screenlocker/ksldapp.cpp f0526cf > > Diff: https://git.reviewboard.kde.org/r/114841/diff/ > > > Testing > ------- > > Configure a Screen saver in systemsettings and wait for it to kick in (or lock the screen manually). > Previously (since 4.10) the mouse cursor stayed visible, now it is blanked like it was the case before 4.10. > Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse cursor appear again as it should, regardless of whether the screen is locked or not. > > > Thanks, > > Wolfgang Bauer > > --===============4183750637587014844== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/

how does that behave with the normal locker (that is no screensaver)?

- Martin Gräßlin

On January 5th, 2014, 9:55 a.m. CET, Wolfgang Bauer wrote:

Review request for kde-workspace and Martin Gräßlin.

By Wolfgang Bauer.

Updated Jan. 5, 2014, 9:55 a.m.

Bugs: 311571, 316459

Repository: kde-workspace

Description

Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the Screen savers from blanking the mouse cursor.

I don't know why this has been done in the first place, but I couldn't see any negative effect by setting it to None. Now the mouse cursor even changes to the IBeam again when over the password field, which I find more intuitive.

Testing

Configure a Screen saver in systemsettings and wait for it to kick in (or lock the screen manually).
Previously (since 4.10) the mouse cursor stayed visible, now it is blanked like it was the case before 4.10.
Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse cursor appear again as it should, regardless of whether the screen is locked or not.

Diffs

ksmserver/screenlocker/ksldapp.cpp (f0526cf)

--===============4183750637587014844==--