[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 112335: In oxygen: Use the iconSize from mainToolbar
From: "Hugo Pereira Da Costa" <hugo () oxygen-icons ! org>
Date: 2014-01-07 8:18:28
Message-ID: 20140107081828.7648.65289 () probe ! kde ! org
[Download RAW message or body]
> On Jan. 7, 2014, 5:44 a.m., Àlex Fiestas wrote:
> > Hey hugo, is this in somehow now that oxygen uses KStyle again?
Hi Alex,
yes this has been removed from Oxygen::pixelMetric
and moved to kstyle::pixelMetric.
However it has the same issue:
case PM_ToolBarIconSize:
return KIconLoader::global()->currentSize(KIconLoader::Toolbar);
so feel free to move the fix there and commit.
Hugo
- Hugo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112335/#review46952
-----------------------------------------------------------
On Aug. 28, 2013, 5:09 p.m., Àlex Fiestas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112335/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2013, 5:09 p.m.)
>
>
> Review request for kde-workspace and Hugo Pereira Da Costa.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> In the qplatformplugin we use information from MainToolbar (which makes sense) but \
> in the styles we use information from Toolbar.
> This unify both by using MainToolbar in styles (if accepted will modify kstyle as \
> well).
>
> Diffs
> -----
>
> kstyles/oxygen/oxygenstyle.cpp 83aaf5c
>
> Diff: https://git.reviewboard.kde.org/r/112335/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Àlex Fiestas
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/112335/">https://git.reviewboard.kde.org/r/112335/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 7th, 2014, 5:44 a.m. UTC, <b>Àlex \
Fiestas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hey hugo, is this in somehow now that oxygen uses KStyle again?</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Alex, yes this has \
been removed from Oxygen::pixelMetric and moved to kstyle::pixelMetric.
However it has the same issue:
case PM_ToolBarIconSize:
return KIconLoader::global()->currentSize(KIconLoader::Toolbar);
so feel free to move the fix there and commit.
Hugo</pre>
<br />
<p>- Hugo</p>
<br />
<p>On August 28th, 2013, 5:09 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Hugo Pereira Da Costa.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2013, 5:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In the qplatformplugin we use information from MainToolbar (which makes \
sense) but in the styles we use information from Toolbar.
This unify both by using MainToolbar in styles (if accepted will modify kstyle as \
well).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyles/oxygen/oxygenstyle.cpp <span style="color: grey">(83aaf5c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/112335/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic