[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2014-01-05 8:55:03
Message-ID: 20140105085503.15366.31183 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114841/
-----------------------------------------------------------
Review request for kde-workspace and Martin Gräßlin.
Bugs: 311571 and 316459
http://bugs.kde.org/show_bug.cgi?id=311571
http://bugs.kde.org/show_bug.cgi?id=316459
Repository: kde-workspace
Description
-------
Setting the cursor to ArrowCursor when calling XGrabPointer() prevents the \
Screen savers from blanking the mouse cursor.
I don't know why this has been done in the first place, but I couldn't see \
any negative effect by setting it to None. Now the mouse cursor even \
changes to the IBeam again when over the password field, which I find more \
intuitive.
Diffs
-----
ksmserver/screenlocker/ksldapp.cpp f0526cf
Diff: https://git.reviewboard.kde.org/r/114841/diff/
Testing
-------
Configure a Screen saver in systemsettings and wait for it to kick in (or \
lock the screen manually). Previously (since 4.10) the mouse cursor stayed \
visible, now it is blanked like it was the case before 4.10. Moving the \
mouse/pressing a key (to quit the Screen saver) makes the mouse cursor \
appear again as it should, regardless of whether the screen is locked or \
not.
Thanks,
Wolfgang Bauer
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114841/">https://git.reviewboard.kde.org/r/114841/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for kde-workspace and Martin Gräßlin.</div>
<div>By Wolfgang Bauer.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311571">311571</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=316459">316459</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Setting the cursor to ArrowCursor when calling XGrabPointer() \
prevents the Screen savers from blanking the mouse cursor.
I don't know why this has been done in the first place, but I \
couldn't see any negative effect by setting it to None. Now the mouse \
cursor even changes to the IBeam again when over the password field, which \
I find more intuitive.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Configure a Screen saver in systemsettings and wait for it to \
kick in (or lock the screen manually). Previously (since 4.10) the mouse \
cursor stayed visible, now it is blanked like it was the case before 4.10. \
Moving the mouse/pressing a key (to quit the Screen saver) makes the mouse \
cursor appear again as it should, regardless of whether the screen is \
locked or not.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: \
grey">(f0526cf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114841/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic