[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 114737: KInfocenter/OpenGL: reimplement the ReadPipe() function with QProcess
From: "Rolf Eike Beer" <kde () opensource ! sf-tec ! de>
Date: 2014-01-04 17:09:32
Message-ID: 20140104170932.11858.65924 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114737/#review46798
-----------------------------------------------------------
Looks fine to me, although I have not tested it.
One minor nitpick (that doesn't deserve a new diff): you could make the FileName \
argument to that function "const QString &".
- Rolf Eike Beer
On Jan. 4, 2014, 4:54 p.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114737/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2014, 4:54 p.m.)
>
>
> Review request for kde-workspace and David Stephen Hubner.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> This patch reimplements the ReadPipe() function by using QProcess instead of \
> popen(). This should make it more portable.
>
> As a positive side-effect, this also removes those "sh: lspci: command not found." \
> messages when run in Konsole and lspci is not in the user's path.
> This was suggested on the kde-core-devel mailinglist in November:
> http://lists.kde.org/?l=kde-core-devel&m=138407113011843&w=2
> http://lists.kde.org/?l=kde-core-devel&m=138409755820003&w=2
>
>
> Diffs
> -----
>
> kinfocenter/Modules/opengl/opengl.cpp 8901957
>
> Diff: https://git.reviewboard.kde.org/r/114737/diff/
>
>
> Testing
> -------
>
> Ran KInfocenter with lspci in /usr/bin/ (i.e. in the user's path) and /sbin/ (not \
> in the user's path). The OpenGL module showed the 3D accelerator info correctly in \
> both cases. With lspci removed completely it showed "unknown" as expected.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114737/">https://git.reviewboard.kde.org/r/114737/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine to me, \
although I have not tested it.
One minor nitpick (that doesn't deserve a new diff): you could make the FileName \
argument to that function "const QString &".</pre> <br />
<p>- Rolf Eike Beer</p>
<br />
<p>On January 4th, 2014, 4:54 p.m. UTC, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and David Stephen Hubner.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2014, 4:54 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch reimplements the ReadPipe() function by using QProcess \
instead of popen(). This should make it more portable.
As a positive side-effect, this also removes those "sh: lspci: command not \
found." messages when run in Konsole and lspci is not in the user's path.
This was suggested on the kde-core-devel mailinglist in November:
http://lists.kde.org/?l=kde-core-devel&m=138407113011843&w=2
http://lists.kde.org/?l=kde-core-devel&m=138409755820003&w=2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran KInfocenter with lspci in /usr/bin/ (i.e. in the user's path) \
and /sbin/ (not in the user's path). The OpenGL module showed the 3D accelerator \
info correctly in both cases. With lspci removed completely it showed \
"unknown" as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kinfocenter/Modules/opengl/opengl.cpp <span style="color: \
grey">(8901957)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114737/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic