[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request 109609: disable session management for screensavers
From: "Wolfgang Bauer" <wbauer () tmo ! at>
Date: 2013-12-31 6:29:48
Message-ID: 20131231062948.1620.39463 () probe ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109609/#review46471
-----------------------------------------------------------
Ping?
Any opinions/comments?
Btw, this patch is part of openSUSE's official KDE packages since September.
- Wolfgang Bauer
On Sept. 11, 2013, 1:15 a.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/109609/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2013, 1:15 a.m.)
>
>
> Review request for kde-workspace and Oliver Henshaw.
>
>
> Bugs: 314859
> http://bugs.kde.org/show_bug.cgi?id=314859
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> This patch disables session management for screensavers.
> Therefore no screensaver windows popup anymore on login if processes keep on \
> running when the user logs out.
> As proposed in https://bugs.kde.org/show_bug.cgi?id=314859#c18
>
> This doesn't solve the underlying problem of bug#224200 of course, but provides \
> better user experience for now, so please accept.
> And IMHO it doesn't make sense to restore screensavers on login, anyway.
>
>
> Diffs
> -----
>
> kscreensaver/libkscreensaver/main.cpp 6851ba1
>
> Diff: https://git.reviewboard.kde.org/r/109609/diff/
>
>
> Testing
> -------
>
> - Turn on the "Blank Screen" (kblankscrn.kss) screensaver in systemsettings.
> - Wait for the screensaver to kick in
> - Verify that the process is still running (due to bug#224200)
> - log out
> - log in again
> Now no "kblankscrn.kss" window is opened anymore (without the patch, a window \
> should appear)
>
> Thanks,
>
> Wolfgang Bauer
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/109609/">https://git.reviewboard.kde.org/r/109609/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ping? Any \
opinions/comments?
Btw, this patch is part of openSUSE's official KDE packages since \
September.</pre> <br />
<p>- Wolfgang Bauer</p>
<br />
<p>On September 11th, 2013, 1:15 a.m. CEST, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Oliver Henshaw.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated Sept. 11, 2013, 1:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314859">314859</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch disables session management for screensavers. Therefore no \
screensaver windows popup anymore on login if processes keep on running when the user \
logs out.
As proposed in https://bugs.kde.org/show_bug.cgi?id=314859#c18
This doesn't solve the underlying problem of bug#224200 of course, but provides \
better user experience for now, so please accept.
And IMHO it doesn't make sense to restore screensavers on login, anyway.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Turn on the "Blank Screen" (kblankscrn.kss) screensaver in \
systemsettings.
- Wait for the screensaver to kick in
- Verify that the process is still running (due to bug#224200)
- log out
- log in again
Now no "kblankscrn.kss" window is opened anymore (without the patch, a \
window should appear)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kscreensaver/libkscreensaver/main.cpp <span style="color: \
grey">(6851ba1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/109609/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic