[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 114537: Fix progressbar's "busy" animation with QtQuickControls
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2013-12-19 11:18:14
Message-ID: 20131219111814.18348.94994 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114537/
-----------------------------------------------------------
Review request for kde-workspace and Hugo Pereira Da Costa.
Repository: kde-workspace
Description
-------
This makes the animated "busy" state of QtQuickControls' progressbar actually move.
Diffs
-----
kstyles/oxygen/animations/oxygenbusyindicatorengine.cpp da4d67e
kstyles/oxygen/oxygenstyle.cpp cf371ca
Diff: http://git.reviewboard.kde.org/r/114537/diff/
Testing
-------
Tested QQC gallery and QWidget5 gallery, both works correctly.
Thanks,
Martin Klapetek
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114537/">http://git.reviewboard.kde.org/r/114537/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Hugo Pereira Da Costa.</div>
<div>By Martin Klapetek.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This makes the animated "busy" state of QtQuickControls' \
progressbar actually move.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested QQC gallery and QWidget5 gallery, both works correctly.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyles/oxygen/animations/oxygenbusyindicatorengine.cpp <span style="color: \
grey">(da4d67e)</span></li>
<li>kstyles/oxygen/oxygenstyle.cpp <span style="color: grey">(cf371ca)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114537/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic