[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Review Request 114449: kjs: Implement ES6 acosh, asinh, cbrt, cosh, exmp1, log1p, log10, sign, s
From:       "Martin Tobias Holmedahl Sandsmark" <martin.sandsmark () kde ! org>
Date:       2013-12-14 16:51:01
Message-ID: 20131214165101.27073.35686 () vidsolbach ! de
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114449/#review45691
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Tobias Holmedahl Sandsmark


On Dec. 14, 2013, 4:30 p.m., Bernd Buschinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114449/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2013, 4:30 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> kjs: Implement ES6 acosh, asinh, cbrt, cosh, exmp1, log1p, log10, sign, sinh, tanh, \
> trunc Math Functions 
> sign, is a bit different from the c++ signbit function, but everything else is just \
> straight forward. 
> 
> Diffs
> -----
> 
> kjs/math_object.h 3d193dd 
> kjs/math_object.cpp 89835e5 
> 
> Diff: http://git.reviewboard.kde.org/r/114449/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bernd Buschinski
> 
> 


[Attachment #3 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114449/">http://git.reviewboard.kde.org/r/114449/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />









<p>- Martin Tobias Holmedahl Sandsmark</p>


<br />
<p>On December 14th, 2013, 4:30 p.m. UTC, Bernd Buschinski wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kdelibs.</div>
<div>By Bernd Buschinski.</div>


<p style="color: grey;"><i>Updated Dec. 14, 2013, 4:30 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kjs: Implement ES6 acosh, asinh, cbrt, cosh, exmp1, log1p, log10, sign, \
sinh, tanh, trunc Math Functions

sign, is a bit different from the c++ signbit function, but everything else is just \
straight forward.</pre>  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kjs/math_object.h <span style="color: grey">(3d193dd)</span></li>

 <li>kjs/math_object.cpp <span style="color: grey">(89835e5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114449/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic