[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Regression of KItemWidgetDelegate in 4.12
From:       Christoph Feck <christoph () maxiom ! de>
Date:       2013-12-11 23:07:53
Message-ID: 201312120007.53262.christoph () maxiom ! de
[Download RAW message or body]

On Wednesday 11 December 2013 22:37:15 Albert Astals Cid wrote:
> Actually i've changed my mind, too much people has already upped
> the version numbers and done preparations, so i've just reverted
> the commits from Andras and will tag 4.12.0 with that.
> 
> If Andras appears and says his commits fix some other case, he has
> a week so he can provide a patch that fixes whatever these patches
> were fixing without breaking the rest of the code using
> KItemWidgetDelegate.

The commits you reverted do not state they fix a bug, so they do not 
belong into branch. Reverting them is the right decision. I do not 
know of previous bugs reported for the delegate either, so there is no 
need to delay the release to test the reverted state.

Christoph Feck (kdepepo)
KDE Quality Team
openSUSE Review Team
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic