El Dimecres, 11 de desembre de 2013, a les 21:45:42, Albert Astals Cid =
va=20
escriure:
> El Dimecres, 11 de desembre de 2013, a les 21:06:20, Thomas L=FCbking=
 va
>=20
> escriure:
> > On Mittwoch, 11. Dezember 2013 20:41:28 CEST, Albert Astals Cid wro=
te:
> > > I am hoping that Andras would let us just revert his changes
> > > since reading the
> > > commit logs seems like they are only optimizations that ended
> > > up wrong (i.e. i hope he wasn't really doing any bugfix).
> >=20
> > Depends on how fast Andras can fix this anyway.
> >=20
> > The introduced 50ms "initializeTimer" was originally not set single=
Shot()
> > but fixed so with commit 5fedc5ee921f87f320b5465edd80f74cabcfefcf o=
nly.
> > (likely bug #327190)
> >=20
> > Therefore I guess the initial constantly fired timer shadowed the n=
ow
> > present issues what basically means the actual changes have (uninte=
ndedly)
> > never been really tested.
> >=20
> > Patches strongly look like optimization (i guess: "this prevents an=
 ugly
> > recursion" would have been commented somewhere....) to me as well, =
so i'd
> > relax, remove them for 4.12.0, this way get Andras enough time to i=
nspect
> > the patches and the *actual* behavior and re-add the correct patch =
for
> > 4.12.1.
> >=20
> > (Unless Andras already *has* a fixing patch, of course ;-)
>=20
> Hmmmmmmm, ok, my suggestion, let's do both what Martin and Thomas sug=
gests,
> let's revert Andras patches and tag/release a RC2 today/tomorrow and =
delay
> the 4.12.0 release a bit more than a week and release on the 30th.
>=20
> This way Andras has a week and a bit to re-fix their commits if it is=
 really
> to have them.

Actually i've changed my mind, too much people has already upped the ve=
rsion=20
numbers and done preparations, so i've just reverted the commits from A=
ndras=20
and will tag 4.12.0 with that.

If Andras appears and says his commits fix some other case, he has a we=
ek so=20
he can provide a patch that fixes whatever these patches were fixing wi=
thout=20
breaking the rest of the code using KItemWidgetDelegate.

Cheers,
  Albert

>=20
> Comments?
>   Albert
>=20
> > Cheers,
> > Thomas
>=20
> _______________________________________________
> release-team mailing list
> release-team@kde.org
> https://mail.kde.org/mailman/listinfo/release-team