[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: Failing testcase in kpasswdservertest [kde-runtime]
From:       Dawit A <adawit () kde ! org>
Date:       2013-12-10 13:57:47
Message-ID: CALa28R6ZUpxB7mxVXdf+y=q=YBq8yUTGze9b3GqBcnNzFhUQ7A () mail ! gmail ! com
[Download RAW message or body]

Sorry for the late response. I did not see this email for some reason. None
of the test cases in testRetryDialog hit that assert on my machine. If this
unit test fails on your system, can you please enable the debug area for
KPasswdServer, run the unit test only for testRetryDialog only and provide
the output from it? I am curious to know why it would start failing all of
the sudden since nothing was changed in that code base in a very long time.


On Mon, Dec 9, 2013 at 6:35 PM, Albert Astals Cid <aacid@kde.org> wrote:

> Dawit? Are you there? Or anyone?
>
> This is still asserting and the tagging of 4.12 is in two days, I'd prefer
> not
> to have to delay it because of the failing test.
>
> Cheers,
>   Albert
>
> El Diumenge, 24 de novembre de 2013, a les 23:26:38, Albert Astals Cid va
> escriure:
> > Hi Dawit, can you please have a look at kpasswdservertest?
> >
> > It's asserting in
> >
> > QFATAL : KPasswdServerTest::testRetryDialog() ASSERT: "request" in file
> >
> /srv/jenkins/workspace/kde-runtime_stable/kpasswdserver/kpasswdserver.cpp,
> > line 1041
> >
> > Looking at the code there's an "if (request)" just after the
> > "Q_ASSERT(request)" so it works in release mode, but i'd like to know if
> >
> > a) we should fix something
> > b) we should just remove the assert
> >
> > To get the test passing again.
> >
> > Cheers,
> >   Albert
>
>

[Attachment #3 (text/html)]

<div dir="ltr">Sorry for the late response. I did not see this email for some reason. \
None of the test cases in testRetryDialog hit that assert on my machine. If this unit \
test fails on your system, can you please enable the debug area for KPasswdServer, \
run the unit test only for testRetryDialog only and provide the output from it? I am \
curious to know why it would start failing all of the sudden since nothing was \
changed in that code base in a very long time.<br>

</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Dec 9, 2013 \
at 6:35 PM, Albert Astals Cid <span dir="ltr">&lt;<a href="mailto:aacid@kde.org" \
target="_blank">aacid@kde.org</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> Dawit? Are you there? Or anyone?<br>
<br>
This is still asserting and the tagging of 4.12 is in two days, I&#39;d prefer \
not<br> to have to delay it because of the failing test.<br>
<br>
Cheers,<br>
   Albert<br>
<br>
El Diumenge, 24 de novembre de 2013, a les 23:26:38, Albert Astals Cid va<br>
escriure:<br>
<div class="HOEnZb"><div class="h5">&gt; Hi Dawit, can you please have a look at \
kpasswdservertest?<br> &gt;<br>
&gt; It&#39;s asserting in<br>
&gt;<br>
&gt; QFATAL : KPasswdServerTest::testRetryDialog() ASSERT: &quot;request&quot; in \
file<br> &gt; /srv/jenkins/workspace/kde-runtime_stable/kpasswdserver/kpasswdserver.cpp,<br>
 &gt; line 1041<br>
&gt;<br>
&gt; Looking at the code there&#39;s an &quot;if (request)&quot; just after the<br>
&gt; &quot;Q_ASSERT(request)&quot; so it works in release mode, but i&#39;d like to \
know if<br> &gt;<br>
&gt; a) we should fix something<br>
&gt; b) we should just remove the assert<br>
&gt;<br>
&gt; To get the test passing again.<br>
&gt;<br>
&gt; Cheers,<br>
&gt;    Albert<br>
<br>
</div></div></blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]