[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Review Request 114226: Make KLimitedIODevice::bytesAvailable return the numbers of bytesAvaliable to
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-11-30 18:40:36
Message-ID: 20131130184036.1147.97023 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114226/
-----------------------------------------------------------
Review request for kdelibs and David Faure.
Bugs: 328182
http://bugs.kde.org/show_bug.cgi?id=328182
Repository: kdelibs
Description
-------
At the moment KLimitedIODevice::bytesAvailable is always returning the size of the file, so \
QIODevice::atEnd never returns true because it thinks there are more bytes to read. This makes \
that if you feed an "invalid" svg like "<?xml version="1.0"?>" to the QImageReader it infinite \
loops believing there will be more stuff to read but then read() always returns 0 but then \
bytesAvailable says there are more and it stays there forever.
Diffs
-----
kdecore/io/klimitediodevice.cpp c93463b
Diff: http://git.reviewboard.kde.org/r/114226/diff/
Testing
-------
The svg renderer does not end loop anymore
Thanks,
Albert Astals Cid
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114226/">http://git.reviewboard.kde.org/r/114226/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Albert Astals Cid.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=328182">328182</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At the moment \
KLimitedIODevice::bytesAvailable is always returning the size of the file, so QIODevice::atEnd \
never returns true because it thinks there are more bytes to read. This makes that if you feed \
an "invalid" svg like "<?xml version="1.0"?>" to the \
QImageReader it infinite loops believing there will be more stuff to read but then read() \
always returns 0 but then bytesAvailable says there are more and it stays there forever.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The svg renderer does \
not end loop anymore</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/io/klimitediodevice.cpp <span style="color: grey">(c93463b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114226/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic